From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK version 3
Date: Wed, 27 Nov 2013 12:32:01 +0100 [thread overview]
Message-ID: <5295D831.1050109@redhat.com> (raw)
In-Reply-To: <1385517991-19194-2-git-send-email-famz@redhat.com>
Il 27/11/2013 03:06, Fam Zheng ha scritto:
> + } else if (le32_to_cpu(header.version) == 3 && flags & BDRV_O_RDWR) {
Parentheses around "flags & BDRV_O_RDWR", please.
I'll try to patch checkpatch.pl to flag this.
Paolo
> + error_setg(errp, "VMDK version 3 must be read only");
> + return -EINVAL;
> }
next prev parent reply other threads:[~2013-11-27 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 2:06 [Qemu-devel] [PATCH 0/2] vmdk: Allow version 3 read only open Fam Zheng
2013-11-27 2:06 ` [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK version 3 Fam Zheng
2013-11-27 11:32 ` Paolo Bonzini [this message]
2013-11-27 2:06 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Add sample image and test for " Fam Zheng
2013-11-27 15:31 ` [Qemu-devel] [PATCH 0/2] vmdk: Allow version 3 read only open Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295D831.1050109@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.