From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property
Date: Wed, 27 Nov 2013 14:10:52 +0100 [thread overview]
Message-ID: <5295EF5C.7070704@suse.de> (raw)
In-Reply-To: <CAEgOgz4TMjsWu2MhP382gSxmGErLsCUZecGGnan_WDjWdQmJZw@mail.gmail.com>
Hi,
Am 27.11.2013 12:39, schrieb Peter Crosthwaite:
> On Wed, Nov 27, 2013 at 8:27 PM, Andreas Färber <afaerber@suse.de> wrote:
>> Am 27.11.2013 11:15, schrieb Peter Maydell:
>>> On 27 November 2013 09:42, Andreas Färber <afaerber@suse.de> wrote:
>>>> If we turn it into a dynamic property, we could register it conditional
>>>> to ARM_FEATURE_CBAR.
>>>
>>> Unfortunately feature flags only get set at realize (in the
>>> per-cpu init function), so we don't know at the point where
>>> we're registering properties whether to have this one or not.
>>
>> 1/6 sets it in instance_init actually. So instance_post_init might do.
>>
>
> Do you have a candidate example of this pattern that I can work off?
For instance_post_init the only user so far will be in hw/core/qdev.c.
target-i386/cpu.c adds a few dynamic properties for the base X86CPU.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-11-27 13:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 9:00 [Qemu-devel] [PATCH arm-devs v1 0/6] Fix Support for ARM A9 CBAR Peter Crosthwaite
2013-11-27 9:01 ` [Qemu-devel] [PATCH arm-devs v1 1/6] target-arm: Define and use ARM_FEATURE_CBAR Peter Crosthwaite
2013-11-27 9:01 ` [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property Peter Crosthwaite
2013-11-27 9:14 ` Peter Maydell
2013-11-27 9:42 ` Andreas Färber
2013-11-27 10:15 ` Peter Maydell
2013-11-27 10:27 ` Andreas Färber
2013-11-27 10:35 ` Peter Maydell
2013-11-27 11:39 ` Peter Crosthwaite
2013-11-27 11:47 ` Peter Maydell
2013-11-28 1:48 ` Peter Crosthwaite
2013-11-27 13:10 ` Andreas Färber [this message]
2013-11-27 9:02 ` [Qemu-devel] [PATCH arm-devs v1 3/6] arm/highbank: Use object_new() rather than cpu_arm_init() Peter Crosthwaite
2013-11-27 9:10 ` Peter Maydell
2013-11-27 9:52 ` Andreas Färber
2013-11-27 9:02 ` [Qemu-devel] [PATCH arm-devs v1 4/6] arm/highbank: Fix CBAR intialisation Peter Crosthwaite
2013-11-27 9:03 ` [Qemu-devel] [PATCH arm-devs v1 5/6] arm/xilinx_zynq: Use object_new() rather than cpu_arm_init() Peter Crosthwaite
2013-11-27 9:04 ` [Qemu-devel] [PATCH arm-devs v1 6/6] arm/xilinx_zynq: Implement CBAR intialisation Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295EF5C.7070704@suse.de \
--to=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=mark.langsdorf@calxeda.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.