From: list-09_linux_arm@tqsc.de (Markus Niebel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DT: imx6qdl: fix can clocks
Date: Wed, 27 Nov 2013 15:09:28 +0100 [thread overview]
Message-ID: <5295FD18.1010501@tqsc.de> (raw)
In-Reply-To: <1385557709.4272.1.camel@weser.hi.pengutronix.de>
Am 27.11.2013 14:08, wrote Lucas Stach:
> Am Mittwoch, den 27.11.2013, 14:14 +0100 schrieb Markus Niebel:
>> From: Markus Niebel <Markus.Niebel@tqs.de>
>>
>> per and ipg clock numbers are exchanged. This leads to
>> wrong bitrate calculation.
>>
> NACK
>
> According to the clock driver clock numbers are IPG->PER.
> I think this is the same problem we encountered on i.MX5 and is fixed
> with commit "can: flexcan: use correct clock as base for bit rate
> calculation"
>
Sorry for the noise, was not aware of this patch. You are right.
>> Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
>> ---
>> arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
>> index 59154dc..797f007 100644
>> --- a/arch/arm/boot/dts/imx6qdl.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
>> @@ -329,7 +329,7 @@
>> compatible = "fsl,imx6q-flexcan";
>> reg = <0x02090000 0x4000>;
>> interrupts = <0 110 0x04>;
>> - clocks = <&clks 108>, <&clks 109>;
>> + clocks = <&clks 109>, <&clks 108>;
>> clock-names = "ipg", "per";
>> };
>>
>> @@ -337,7 +337,7 @@
>> compatible = "fsl,imx6q-flexcan";
>> reg = <0x02094000 0x4000>;
>> interrupts = <0 111 0x04>;
>> - clocks = <&clks 110>, <&clks 111>;
>> + clocks = <&clks 111>, <&clks 110>;
>> clock-names = "ipg", "per";
>> };
>>
>
prev parent reply other threads:[~2013-11-27 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 13:14 [PATCH] ARM: DT: imx6qdl: fix can clocks Markus Niebel
2013-11-27 13:08 ` Lucas Stach
2013-11-27 14:09 ` Markus Niebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295FD18.1010501@tqsc.de \
--to=list-09_linux_arm@tqsc.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.