* [PATCH] ARM: DT: imx6qdl: fix can clocks
@ 2013-11-27 13:14 Markus Niebel
2013-11-27 13:08 ` Lucas Stach
0 siblings, 1 reply; 3+ messages in thread
From: Markus Niebel @ 2013-11-27 13:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Markus Niebel <Markus.Niebel@tqs.de>
per and ipg clock numbers are exchanged. This leads to
wrong bitrate calculation.
Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
---
arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 59154dc..797f007 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -329,7 +329,7 @@
compatible = "fsl,imx6q-flexcan";
reg = <0x02090000 0x4000>;
interrupts = <0 110 0x04>;
- clocks = <&clks 108>, <&clks 109>;
+ clocks = <&clks 109>, <&clks 108>;
clock-names = "ipg", "per";
};
@@ -337,7 +337,7 @@
compatible = "fsl,imx6q-flexcan";
reg = <0x02094000 0x4000>;
interrupts = <0 111 0x04>;
- clocks = <&clks 110>, <&clks 111>;
+ clocks = <&clks 111>, <&clks 110>;
clock-names = "ipg", "per";
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: DT: imx6qdl: fix can clocks
2013-11-27 13:14 [PATCH] ARM: DT: imx6qdl: fix can clocks Markus Niebel
@ 2013-11-27 13:08 ` Lucas Stach
2013-11-27 14:09 ` Markus Niebel
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2013-11-27 13:08 UTC (permalink / raw)
To: linux-arm-kernel
Am Mittwoch, den 27.11.2013, 14:14 +0100 schrieb Markus Niebel:
> From: Markus Niebel <Markus.Niebel@tqs.de>
>
> per and ipg clock numbers are exchanged. This leads to
> wrong bitrate calculation.
>
NACK
According to the clock driver clock numbers are IPG->PER.
I think this is the same problem we encountered on i.MX5 and is fixed
with commit "can: flexcan: use correct clock as base for bit rate
calculation"
> Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 59154dc..797f007 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -329,7 +329,7 @@
> compatible = "fsl,imx6q-flexcan";
> reg = <0x02090000 0x4000>;
> interrupts = <0 110 0x04>;
> - clocks = <&clks 108>, <&clks 109>;
> + clocks = <&clks 109>, <&clks 108>;
> clock-names = "ipg", "per";
> };
>
> @@ -337,7 +337,7 @@
> compatible = "fsl,imx6q-flexcan";
> reg = <0x02094000 0x4000>;
> interrupts = <0 111 0x04>;
> - clocks = <&clks 110>, <&clks 111>;
> + clocks = <&clks 111>, <&clks 110>;
> clock-names = "ipg", "per";
> };
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: DT: imx6qdl: fix can clocks
2013-11-27 13:08 ` Lucas Stach
@ 2013-11-27 14:09 ` Markus Niebel
0 siblings, 0 replies; 3+ messages in thread
From: Markus Niebel @ 2013-11-27 14:09 UTC (permalink / raw)
To: linux-arm-kernel
Am 27.11.2013 14:08, wrote Lucas Stach:
> Am Mittwoch, den 27.11.2013, 14:14 +0100 schrieb Markus Niebel:
>> From: Markus Niebel <Markus.Niebel@tqs.de>
>>
>> per and ipg clock numbers are exchanged. This leads to
>> wrong bitrate calculation.
>>
> NACK
>
> According to the clock driver clock numbers are IPG->PER.
> I think this is the same problem we encountered on i.MX5 and is fixed
> with commit "can: flexcan: use correct clock as base for bit rate
> calculation"
>
Sorry for the noise, was not aware of this patch. You are right.
>> Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
>> ---
>> arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
>> index 59154dc..797f007 100644
>> --- a/arch/arm/boot/dts/imx6qdl.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
>> @@ -329,7 +329,7 @@
>> compatible = "fsl,imx6q-flexcan";
>> reg = <0x02090000 0x4000>;
>> interrupts = <0 110 0x04>;
>> - clocks = <&clks 108>, <&clks 109>;
>> + clocks = <&clks 109>, <&clks 108>;
>> clock-names = "ipg", "per";
>> };
>>
>> @@ -337,7 +337,7 @@
>> compatible = "fsl,imx6q-flexcan";
>> reg = <0x02094000 0x4000>;
>> interrupts = <0 111 0x04>;
>> - clocks = <&clks 110>, <&clks 111>;
>> + clocks = <&clks 111>, <&clks 110>;
>> clock-names = "ipg", "per";
>> };
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-27 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-27 13:14 [PATCH] ARM: DT: imx6qdl: fix can clocks Markus Niebel
2013-11-27 13:08 ` Lucas Stach
2013-11-27 14:09 ` Markus Niebel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.