All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre COFFIGNAL <acoffignal@geral.com>
To: xenomai@xenomai.org
Subject: [Xenomai] rtcan_flexcan on a i.MX28 board
Date: Wed, 27 Nov 2013 18:32:48 +0100	[thread overview]
Message-ID: <52962CC0.20505@geral.com> (raw)

Hi all.

I'm trying to use rtcan_flexcan on a i.MX28 board with Xenomai 2.6.3 
under Linux v3.8.13.
I use a dtb file and it seem to be a mistake in flexcan_probe function.

If flexcan device id is found in dtb, devtype_data points to the 
flexcan_id_table driver_data structure. In this case, the condition in 
flexcan_probe function (!devtype_data && pdev->id_entry->driver_data) 
will always fail and it will always return ENODEV, whereas devtype_data 
points to a valid value.

I submit this patch which fixes this issue

Best regards,
Alex.
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xenomai-rtcan_flexcan-fix-devtype_data-initialization.patch
Type: text/x-patch
Size: 857 bytes
Desc: not available
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20131127/cade88f3/attachment.bin>

             reply	other threads:[~2013-11-27 17:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 17:32 Alexandre COFFIGNAL [this message]
2013-11-27 20:02 ` [Xenomai] rtcan_flexcan on a i.MX28 board Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52962CC0.20505@geral.com \
    --to=acoffignal@geral.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.