All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Alexandre COFFIGNAL <acoffignal@geral.com>, xenomai@xenomai.org
Subject: Re: [Xenomai] rtcan_flexcan on a i.MX28 board
Date: Wed, 27 Nov 2013 21:02:30 +0100	[thread overview]
Message-ID: <52964FD6.6090802@grandegger.com> (raw)
In-Reply-To: <52962CC0.20505@geral.com>

Hi Alexandre,

On 11/27/2013 06:32 PM, Alexandre COFFIGNAL wrote:
> Hi all.
> 
> I'm trying to use rtcan_flexcan on a i.MX28 board with Xenomai 2.6.3
> under Linux v3.8.13.
> I use a dtb file and it seem to be a mistake in flexcan_probe function.
> 
> If flexcan device id is found in dtb, devtype_data points to the
> flexcan_id_table driver_data structure. In this case, the condition in
> flexcan_probe function (!devtype_data && pdev->id_entry->driver_data)
> will always fail and it will always return ENODEV, whereas devtype_data
> points to a valid value.

I see the problem. It should be like in the Linux kernel:

http://lxr.linux.no/#linux/drivers/net/can/flexcan.c#L1041

> I submit this patch which fixes this issue

Could you please send your patch inline in a separate mail with the
subject "[PATCH] rtcan_flexcan: ...".  Apart from that, I your RTCAN
Flexcan driver working properly, I assume.

Wolfgang.



      reply	other threads:[~2013-11-27 20:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 17:32 [Xenomai] rtcan_flexcan on a i.MX28 board Alexandre COFFIGNAL
2013-11-27 20:02 ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52964FD6.6090802@grandegger.com \
    --to=wg@grandegger.com \
    --cc=acoffignal@geral.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.