* [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper
@ 2022-08-27 9:41 ` Yang Yingliang
0 siblings, 0 replies; 14+ messages in thread
From: Yang Yingliang @ 2022-08-27 9:41 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk
Cc: mturquette, sboyd, wens, jernej.skrabec
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 28 +++++++++-------------------
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
index 2f6f02f00be2..b70b312e7483 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
@@ -256,29 +256,19 @@ static int sunxi_de2_clk_probe(struct platform_device *pdev)
return PTR_ERR(reg);
bus_clk = devm_clk_get(&pdev->dev, "bus");
- if (IS_ERR(bus_clk)) {
- ret = PTR_ERR(bus_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(bus_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+ "Couldn't get bus clk\n");
mod_clk = devm_clk_get(&pdev->dev, "mod");
- if (IS_ERR(mod_clk)) {
- ret = PTR_ERR(mod_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Couldn't get mod clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(mod_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(mod_clk),
+ "Couldn't get mod clk\n");
rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
- if (IS_ERR(rstc)) {
- ret = PTR_ERR(rstc);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "Couldn't get reset control: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(rstc))
+ return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
+ "Couldn't get reset control\n");
/* The clocks need to be enabled for us to access the registers */
ret = clk_prepare_enable(bus_clk);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH -next 2/3] clk: sunxi-ng: ccu-sun9i-a80-de: Use dev_err_probe() helper
2022-08-27 9:41 ` Yang Yingliang
@ 2022-08-27 9:41 ` Yang Yingliang
-1 siblings, 0 replies; 14+ messages in thread
From: Yang Yingliang @ 2022-08-27 9:41 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk
Cc: mturquette, sboyd, wens, jernej.skrabec
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
index f2fe0e1cc3c0..1d8b1ae1619d 100644
--- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
+++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
@@ -213,21 +213,14 @@ static int sun9i_a80_de_clk_probe(struct platform_device *pdev)
return PTR_ERR(reg);
bus_clk = devm_clk_get(&pdev->dev, "bus");
- if (IS_ERR(bus_clk)) {
- ret = PTR_ERR(bus_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(bus_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+ "Couldn't get bus clk\n");
rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
- if (IS_ERR(rstc)) {
- ret = PTR_ERR(rstc);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "Couldn't get reset control: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(rstc))
+ return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
+ "Couldn't get reset control\n");
/* The bus clock needs to be enabled for us to access the registers */
ret = clk_prepare_enable(bus_clk);
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH -next 2/3] clk: sunxi-ng: ccu-sun9i-a80-de: Use dev_err_probe() helper
@ 2022-08-27 9:41 ` Yang Yingliang
0 siblings, 0 replies; 14+ messages in thread
From: Yang Yingliang @ 2022-08-27 9:41 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk
Cc: mturquette, sboyd, wens, jernej.skrabec
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
index f2fe0e1cc3c0..1d8b1ae1619d 100644
--- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
+++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
@@ -213,21 +213,14 @@ static int sun9i_a80_de_clk_probe(struct platform_device *pdev)
return PTR_ERR(reg);
bus_clk = devm_clk_get(&pdev->dev, "bus");
- if (IS_ERR(bus_clk)) {
- ret = PTR_ERR(bus_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(bus_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+ "Couldn't get bus clk\n");
rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
- if (IS_ERR(rstc)) {
- ret = PTR_ERR(rstc);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "Couldn't get reset control: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(rstc))
+ return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
+ "Couldn't get reset control\n");
/* The bus clock needs to be enabled for us to access the registers */
ret = clk_prepare_enable(bus_clk);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH -next 2/3] clk: sunxi-ng: ccu-sun9i-a80-de: Use dev_err_probe() helper
2022-08-27 9:41 ` Yang Yingliang
@ 2022-08-27 11:07 ` Jernej Škrabec
-1 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-08-27 11:07 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:50 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
> b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c index f2fe0e1cc3c0..1d8b1ae1619d
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
> @@ -213,21 +213,14 @@ static int sun9i_a80_de_clk_probe(struct
> platform_device *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> - if (IS_ERR(rstc)) {
> - ret = PTR_ERR(rstc);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Couldn't get reset control:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(rstc))
> + return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
> + "Couldn't get reset
control\n");
>
> /* The bus clock needs to be enabled for us to access the
registers */
> ret = clk_prepare_enable(bus_clk);
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH -next 2/3] clk: sunxi-ng: ccu-sun9i-a80-de: Use dev_err_probe() helper
@ 2022-08-27 11:07 ` Jernej Škrabec
0 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-08-27 11:07 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:50 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
> b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c index f2fe0e1cc3c0..1d8b1ae1619d
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c
> @@ -213,21 +213,14 @@ static int sun9i_a80_de_clk_probe(struct
> platform_device *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> - if (IS_ERR(rstc)) {
> - ret = PTR_ERR(rstc);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Couldn't get reset control:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(rstc))
> + return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
> + "Couldn't get reset
control\n");
>
> /* The bus clock needs to be enabled for us to access the
registers */
> ret = clk_prepare_enable(bus_clk);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper
2022-08-27 9:41 ` Yang Yingliang
@ 2022-08-27 9:41 ` Yang Yingliang
-1 siblings, 0 replies; 14+ messages in thread
From: Yang Yingliang @ 2022-08-27 9:41 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk
Cc: mturquette, sboyd, wens, jernej.skrabec
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
index 575ae4ccc65f..a0fb0da8f356 100644
--- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
+++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
@@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct platform_device *pdev)
return PTR_ERR(reg);
bus_clk = devm_clk_get(&pdev->dev, "bus");
- if (IS_ERR(bus_clk)) {
- ret = PTR_ERR(bus_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(bus_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+ "Couldn't get bus clk\n");
/* The bus clock needs to be enabled for us to access the registers */
ret = clk_prepare_enable(bus_clk);
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper
@ 2022-08-27 9:41 ` Yang Yingliang
0 siblings, 0 replies; 14+ messages in thread
From: Yang Yingliang @ 2022-08-27 9:41 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk
Cc: mturquette, sboyd, wens, jernej.skrabec
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
index 575ae4ccc65f..a0fb0da8f356 100644
--- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
+++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
@@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct platform_device *pdev)
return PTR_ERR(reg);
bus_clk = devm_clk_get(&pdev->dev, "bus");
- if (IS_ERR(bus_clk)) {
- ret = PTR_ERR(bus_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(bus_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+ "Couldn't get bus clk\n");
/* The bus clock needs to be enabled for us to access the registers */
ret = clk_prepare_enable(bus_clk);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper
2022-08-27 9:41 ` Yang Yingliang
@ 2022-08-27 11:07 ` Jernej Škrabec
-1 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-08-27 11:07 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:51 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c index 575ae4ccc65f..a0fb0da8f356
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> @@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct
> platform_device *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> /* The bus clock needs to be enabled for us to access the
registers */
> ret = clk_prepare_enable(bus_clk);
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper
@ 2022-08-27 11:07 ` Jernej Škrabec
0 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-08-27 11:07 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:51 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c index 575ae4ccc65f..a0fb0da8f356
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c
> @@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct
> platform_device *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> /* The bus clock needs to be enabled for us to access the
registers */
> ret = clk_prepare_enable(bus_clk);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper
2022-08-27 9:41 ` Yang Yingliang
@ 2022-08-27 11:07 ` Jernej Škrabec
-1 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-08-27 11:07 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:49 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 28 +++++++++-------------------
> 1 file changed, 9 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
> b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c index 2f6f02f00be2..b70b312e7483
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
> @@ -256,29 +256,19 @@ static int sunxi_de2_clk_probe(struct platform_device
> *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> mod_clk = devm_clk_get(&pdev->dev, "mod");
> - if (IS_ERR(mod_clk)) {
> - ret = PTR_ERR(mod_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get mod clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(mod_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(mod_clk),
> + "Couldn't get mod clk\n");
>
> rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> - if (IS_ERR(rstc)) {
> - ret = PTR_ERR(rstc);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Couldn't get reset control:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(rstc))
> + return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
> + "Couldn't get reset
control\n");
>
> /* The clocks need to be enabled for us to access the registers */
> ret = clk_prepare_enable(bus_clk);
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper
@ 2022-08-27 11:07 ` Jernej Škrabec
0 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-08-27 11:07 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:49 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 28 +++++++++-------------------
> 1 file changed, 9 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
> b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c index 2f6f02f00be2..b70b312e7483
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
> @@ -256,29 +256,19 @@ static int sunxi_de2_clk_probe(struct platform_device
> *pdev) return PTR_ERR(reg);
>
> bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(bus_clk)) {
> - ret = PTR_ERR(bus_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get bus clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(bus_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
> + "Couldn't get bus clk\n");
>
> mod_clk = devm_clk_get(&pdev->dev, "mod");
> - if (IS_ERR(mod_clk)) {
> - ret = PTR_ERR(mod_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Couldn't get mod clk:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(mod_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(mod_clk),
> + "Couldn't get mod clk\n");
>
> rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> - if (IS_ERR(rstc)) {
> - ret = PTR_ERR(rstc);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Couldn't get reset control:
%d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(rstc))
> + return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
> + "Couldn't get reset
control\n");
>
> /* The clocks need to be enabled for us to access the registers */
> ret = clk_prepare_enable(bus_clk);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper
2022-08-27 9:41 ` Yang Yingliang
@ 2022-09-08 19:55 ` Jernej Škrabec
-1 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-09-08 19:55 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:49 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied all three, thanks!
Best regards,
Jernej
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper
@ 2022-09-08 19:55 ` Jernej Škrabec
0 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2022-09-08 19:55 UTC (permalink / raw)
To: linux-kernel, linux-sunxi, linux-arm-kernel, linux-clk,
Yang Yingliang
Cc: mturquette, sboyd, wens
Dne sobota, 27. avgust 2022 ob 11:41:49 CEST je Yang Yingliang napisal(a):
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied all three, thanks!
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread