From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-clk@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] clk: samsung: cpu: prepare for adding Exynos5433 CPU clocks
Date: Mon, 20 Jun 2016 15:54:53 +0200 [thread overview]
Message-ID: <5297672.nIMnaEh2jc@amdc1976> (raw)
In-Reply-To: <CA+Ln22FwQ_e5OHg_8WHEWGER=X8g_Yq+NpVLONgb0ZAShJLjzA@mail.gmail.com>
On Saturday, June 18, 2016 11:53:36 PM Tomasz Figa wrote:
> Hi Bart,
Hi Tomek,
> 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Exynos5433 uses different register layout for CPU clock registers
> > than earlier SoCs so add new code for handling this layout. Also
> > add new CLK_CPU_HAS_E5433_REGS_LAYOUT flag to request using it.
>
> Have you considered abstracting this? Comparing existing code with
Yes, I have considered abstracting this but I've decided that there is
sufficient number of differences to justify adding new code.
> newly added one, the differences don't really seem to be that huge and
> it looks like there is more common code than different, except maybe
> some numeric constants that could be put into a struct.
It is not only that, HPM clock sourcing checking would also need to be
abstracted somehow. Anyway there is not a lot of new code and it so
much easier to follow by not being shared that I would prefer to keep
it that way.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-clk@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] clk: samsung: cpu: prepare for adding Exynos5433 CPU clocks
Date: Mon, 20 Jun 2016 15:54:53 +0200 [thread overview]
Message-ID: <5297672.nIMnaEh2jc@amdc1976> (raw)
In-Reply-To: <CA+Ln22FwQ_e5OHg_8WHEWGER=X8g_Yq+NpVLONgb0ZAShJLjzA@mail.gmail.com>
On Saturday, June 18, 2016 11:53:36 PM Tomasz Figa wrote:
> Hi Bart,
Hi Tomek,
> 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Exynos5433 uses different register layout for CPU clock registers
> > than earlier SoCs so add new code for handling this layout. Also
> > add new CLK_CPU_HAS_E5433_REGS_LAYOUT flag to request using it.
>
> Have you considered abstracting this? Comparing existing code with
Yes, I have considered abstracting this but I've decided that there is
sufficient number of differences to justify adding new code.
> newly added one, the differences don't really seem to be that huge and
> it looks like there is more common code than different, except maybe
> some numeric constants that could be put into a struct.
It is not only that, HPM clock sourcing checking would also need to be
abstracted somehow. Anyway there is not a lot of new code and it so
much easier to follow by not being shared that I would prefer to keep
it that way.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clk: samsung: cpu: prepare for adding Exynos5433 CPU clocks
Date: Mon, 20 Jun 2016 15:54:53 +0200 [thread overview]
Message-ID: <5297672.nIMnaEh2jc@amdc1976> (raw)
In-Reply-To: <CA+Ln22FwQ_e5OHg_8WHEWGER=X8g_Yq+NpVLONgb0ZAShJLjzA@mail.gmail.com>
On Saturday, June 18, 2016 11:53:36 PM Tomasz Figa wrote:
> Hi Bart,
Hi Tomek,
> 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Exynos5433 uses different register layout for CPU clock registers
> > than earlier SoCs so add new code for handling this layout. Also
> > add new CLK_CPU_HAS_E5433_REGS_LAYOUT flag to request using it.
>
> Have you considered abstracting this? Comparing existing code with
Yes, I have considered abstracting this but I've decided that there is
sufficient number of differences to justify adding new code.
> newly added one, the differences don't really seem to be that huge and
> it looks like there is more common code than different, except maybe
> some numeric constants that could be put into a struct.
It is not only that, HPM clock sourcing checking would also need to be
abstracted somehow. Anyway there is not a lot of new code and it so
much easier to follow by not being shared that I would prefer to keep
it that way.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2016-06-20 13:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:19 [PATCH 0/3] clk: samsung: add Exynos5433 CPU clocks Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` [PATCH 1/3] clk: samsung: exynos5433: prepare for adding " Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` Bartlomiej Zolnierkiewicz
2016-05-25 8:19 ` Krzysztof Kozlowski
2016-05-25 8:19 ` Krzysztof Kozlowski
2016-06-18 14:40 ` Tomasz Figa
2016-06-18 14:40 ` Tomasz Figa
2016-06-20 13:35 ` Bartlomiej Zolnierkiewicz
2016-06-20 13:35 ` Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` [PATCH 2/3] clk: samsung: cpu: prepare for adding Exynos5433 " Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` Bartlomiej Zolnierkiewicz
2016-05-25 8:31 ` Krzysztof Kozlowski
2016-05-25 8:31 ` Krzysztof Kozlowski
2016-06-18 14:53 ` Tomasz Figa
2016-06-18 14:53 ` Tomasz Figa
2016-06-20 13:54 ` Bartlomiej Zolnierkiewicz [this message]
2016-06-20 13:54 ` Bartlomiej Zolnierkiewicz
2016-06-20 13:54 ` Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` [PATCH 3/3] clk: samsung: exynos5433: add CPU clocks configuration data and instantiate " Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` Bartlomiej Zolnierkiewicz
2016-05-25 9:34 ` Krzysztof Kozlowski
2016-05-25 9:34 ` Krzysztof Kozlowski
2016-06-18 14:57 ` Tomasz Figa
2016-06-18 14:57 ` Tomasz Figa
2016-06-20 13:57 ` Bartlomiej Zolnierkiewicz
2016-06-20 13:57 ` Bartlomiej Zolnierkiewicz
2016-06-20 13:57 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5297672.nIMnaEh2jc@amdc1976 \
--to=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.