From: Hector Palacios <hector.palacios@digi.com>
To: Marek Vasut <marex@denx.de>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"b32955@freescale.com" <b32955@freescale.com>,
"fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 0/3] serial: mxs-auart: flush_buffer hook and interrupt processing
Date: Fri, 29 Nov 2013 17:46:44 +0100 [thread overview]
Message-ID: <5298C4F4.1020507@digi.com> (raw)
In-Reply-To: <201311291744.06943.marex@denx.de>
On 11/29/2013 05:44 PM, Marek Vasut wrote:
> Hi Hector,
>
>> Hello,
>>
>> This series implement several fixes to the mxs-auart serial driver.
>>
>> The first patch implements the flush_buffer hook. Currently the driver
>> can be shut down and pending data in the FIFO will be lost.
>>
>> The second patchs adds a check of the BUSY flag in the tx_empty hook
>> to make sure the UART is not about to fill data into the FIFO.
>>
>> The third patch moves the interrupt handling from the ISR out to a
>> tasklet. This was motivated due to different transmission problems
>> with hardware and software flow control at high baudrates whereby
>> transmission was interrupted or data lost.
>> The problem can be reproduced by setting two AUARTs at 576000/N/8
>> with CRTSCTS and sending a large file from one port to the other
>> with 'cat'.
>
> 57600 is not that high of a baudrate. Or do you really mean 576000 (576
> thousand) ?
I wrote and meant 576000, indeed :-)
Best regards,
--
Hector Palacios
WARNING: multiple messages have this Message-ID (diff)
From: hector.palacios@digi.com (Hector Palacios)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] serial: mxs-auart: flush_buffer hook and interrupt processing
Date: Fri, 29 Nov 2013 17:46:44 +0100 [thread overview]
Message-ID: <5298C4F4.1020507@digi.com> (raw)
In-Reply-To: <201311291744.06943.marex@denx.de>
On 11/29/2013 05:44 PM, Marek Vasut wrote:
> Hi Hector,
>
>> Hello,
>>
>> This series implement several fixes to the mxs-auart serial driver.
>>
>> The first patch implements the flush_buffer hook. Currently the driver
>> can be shut down and pending data in the FIFO will be lost.
>>
>> The second patchs adds a check of the BUSY flag in the tx_empty hook
>> to make sure the UART is not about to fill data into the FIFO.
>>
>> The third patch moves the interrupt handling from the ISR out to a
>> tasklet. This was motivated due to different transmission problems
>> with hardware and software flow control at high baudrates whereby
>> transmission was interrupted or data lost.
>> The problem can be reproduced by setting two AUARTs at 576000/N/8
>> with CRTSCTS and sending a large file from one port to the other
>> with 'cat'.
>
> 57600 is not that high of a baudrate. Or do you really mean 576000 (576
> thousand) ?
I wrote and meant 576000, indeed :-)
Best regards,
--
Hector Palacios
next prev parent reply other threads:[~2013-11-29 16:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 16:35 [PATCH 0/3] serial: mxs-auart: flush_buffer hook and interrupt processing Hector Palacios
2013-11-29 16:35 ` Hector Palacios
2013-11-29 16:35 ` [PATCH 1/3] serial: mxs-auart: implement flush_buffer hook Hector Palacios
2013-11-29 16:35 ` Hector Palacios
2013-11-29 16:50 ` Marek Vasut
2013-11-29 16:50 ` Marek Vasut
2013-11-29 17:49 ` Hector Palacios
2013-11-29 17:49 ` Hector Palacios
2013-11-29 18:02 ` Marek Vasut
2013-11-29 18:02 ` Marek Vasut
2013-11-29 18:02 ` Lucas Stach
2013-11-29 18:02 ` Lucas Stach
2013-11-29 16:35 ` [PATCH 2/3] serial: mxs-auart: check BUSY flag on tx_empty hook Hector Palacios
2013-11-29 16:35 ` Hector Palacios
2013-11-29 16:35 ` [PATCH 3/3] serial: mxs-auart: move irq handling to a tasklet Hector Palacios
2013-11-29 16:35 ` Hector Palacios
2013-11-29 17:00 ` Marek Vasut
2013-11-29 17:00 ` Marek Vasut
2013-11-29 18:04 ` Hector Palacios
2013-11-29 18:04 ` Hector Palacios
2013-11-29 16:44 ` [PATCH 0/3] serial: mxs-auart: flush_buffer hook and interrupt processing Marek Vasut
2013-11-29 16:44 ` Marek Vasut
2013-11-29 16:46 ` Hector Palacios [this message]
2013-11-29 16:46 ` Hector Palacios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298C4F4.1020507@digi.com \
--to=hector.palacios@digi.com \
--cc=b32955@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=marex@denx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.