All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/3] fence_ipmilan: option --method and new option --ipmitool-path
Date: Fri, 29 Nov 2013 22:39:04 +0100	[thread overview]
Message-ID: <52990978.2040406@redhat.com> (raw)
In-Reply-To: <602750918.3048711.1385742741085.JavaMail.root@redhat.com>

On 11/29/2013 05:32 PM, Ondrej Mular wrote:

> @@ -147,28 +160,44 @@ def define_new_opts():
>      all_opt["privlvl"] = {
>          "getopt" : "P:",
>          "longopt" : "privlvl",
> -        "help" : "-P, --privlvl=[level]    Privilege level on IPMI device (callback|user|operator|administrator)",
> +        "help" : "-P, --privlvl=[level]          Privilege level on IPMI device (callback|user|operator|administrator)",

All the reformatting and cosmetic changes should be in a separate commit.

Also, this patch assumes that the first patch you posted is applied to
the tree. It's not. Sending incremental patches over patches makes it
difficult to rebuild the final binary and test it (yes I have ipmi
devices at home :))

Fabio



      parent reply	other threads:[~2013-11-29 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <541560872.3047918.1385742157830.JavaMail.root@redhat.com>
2013-11-29 16:32 ` [Cluster-devel] [PATCH 2/3] fence_ipmilan: option --method and new option --ipmitool-path Ondrej Mular
2013-11-29 21:36   ` Fabio M. Di Nitto
2013-11-29 21:39   ` Fabio M. Di Nitto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52990978.2040406@redhat.com \
    --to=fdinitto@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.