All of lore.kernel.org
 help / color / mirror / Atom feed
From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: add usart3 alias to dtsi
Date: Mon, 02 Dec 2013 12:36:39 +0100	[thread overview]
Message-ID: <529C70C7.9050707@overkiz.com> (raw)
In-Reply-To: <1385979186-29447-1-git-send-email-nicolas.ferre@atmel.com>

Hi Nicolas,

Le 02/12/2013 11:13, Nicolas Ferre a ?crit :
> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
> Preripheral node and pinctrl declarations are already in the
> at91sam9x5_usart3.dtsi file.
>
> Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>   arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
>   arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
> index 17b879990914..d4650b4e9ebb 100644
> --- a/arch/arm/boot/dts/at91sam9g25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g25.dtsi
> @@ -14,6 +14,10 @@
>   	model = "Atmel AT91SAM9G25 SoC";
>   	compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
>   
> +	aliases {
> +		serial4 = &usart3;
> +	};
> +

Shouldn't this go into at91sam9x5_usart3.dtsi ?
This way you would have the same alias for all the SoCs supporting usart3.

Best Regards,

Boris

>   	ahb {
>   		apb {
>   			pinctrl at fffff400 {
> diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
> index c2554219f7a4..aceee86f60eb 100644
> --- a/arch/arm/boot/dts/at91sam9x25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x25.dtsi
> @@ -15,6 +15,10 @@
>   	model = "Atmel AT91SAM9X25 SoC";
>   	compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
>   
> +	aliases {
> +		serial4 = &usart3;
> +	};
> +
>   	ahb {
>   		apb {
>   			pinctrl at fffff400 {

WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, jiri.prchal@aksignal.cz
Subject: Re: [PATCH] ARM: at91: add usart3 alias to dtsi
Date: Mon, 02 Dec 2013 12:36:39 +0100	[thread overview]
Message-ID: <529C70C7.9050707@overkiz.com> (raw)
In-Reply-To: <1385979186-29447-1-git-send-email-nicolas.ferre@atmel.com>

Hi Nicolas,

Le 02/12/2013 11:13, Nicolas Ferre a écrit :
> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
> Preripheral node and pinctrl declarations are already in the
> at91sam9x5_usart3.dtsi file.
>
> Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>   arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
>   arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
> index 17b879990914..d4650b4e9ebb 100644
> --- a/arch/arm/boot/dts/at91sam9g25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g25.dtsi
> @@ -14,6 +14,10 @@
>   	model = "Atmel AT91SAM9G25 SoC";
>   	compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
>   
> +	aliases {
> +		serial4 = &usart3;
> +	};
> +

Shouldn't this go into at91sam9x5_usart3.dtsi ?
This way you would have the same alias for all the SoCs supporting usart3.

Best Regards,

Boris

>   	ahb {
>   		apb {
>   			pinctrl@fffff400 {
> diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
> index c2554219f7a4..aceee86f60eb 100644
> --- a/arch/arm/boot/dts/at91sam9x25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x25.dtsi
> @@ -15,6 +15,10 @@
>   	model = "Atmel AT91SAM9X25 SoC";
>   	compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
>   
> +	aliases {
> +		serial4 = &usart3;
> +	};
> +
>   	ahb {
>   		apb {
>   			pinctrl@fffff400 {


  reply	other threads:[~2013-12-02 11:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 10:13 [PATCH] ARM: at91: add usart3 alias to dtsi Nicolas Ferre
2013-12-02 10:13 ` Nicolas Ferre
2013-12-02 11:36 ` boris brezillon [this message]
2013-12-02 11:36   ` boris brezillon
2013-12-02 12:47   ` Nicolas Ferre
2013-12-02 12:47     ` Nicolas Ferre
2013-12-02 12:53 ` [PATCH v2] " Nicolas Ferre
2013-12-02 12:53   ` Nicolas Ferre
2013-12-02 12:55   ` boris brezillon
2013-12-02 12:55     ` boris brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529C70C7.9050707@overkiz.com \
    --to=b.brezillon@overkiz.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.