From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, armbru@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 3/8] qapi script: check correctness of discriminator values in union
Date: Mon, 02 Dec 2013 12:44:26 -0700 [thread overview]
Message-ID: <529CE31A.9000300@redhat.com> (raw)
In-Reply-To: <1384295108-10913-4-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
On 11/12/2013 03:25 PM, Wenchao Xia wrote:
> It will check whether the values specified are written correctly,
> and whether all enum values are covered, when discriminator is a
> pre-defined enum type
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> scripts/qapi-visit.py | 17 +++++++++++++++++
> scripts/qapi.py | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 48 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-12-02 19:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 22:25 [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name Wenchao Xia
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 1/8] qapi script: remember enum values Wenchao Xia
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 2/8] qapi script: add check for duplicated key Wenchao Xia
2013-12-02 19:42 ` Eric Blake
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 3/8] qapi script: check correctness of discriminator values in union Wenchao Xia
2013-12-02 19:44 ` Eric Blake [this message]
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 4/8] qapi script: code move for generate_enum_name() Wenchao Xia
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 5/8] qapi script: use same function to generate enum string Wenchao Xia
2013-12-02 20:17 ` Eric Blake
2013-12-03 2:55 ` Wenchao Xia
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 6/8] qapi script: not generate hidden enum type for pre-defined enum discriminator Wenchao Xia
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 7/8] qapi script: do not add "_" for every capitalized char in enum Wenchao Xia
2013-12-02 20:21 ` Eric Blake
2013-11-12 22:25 ` [Qemu-devel] [PATCH V2 8/8] tests: add cases for inherited struct and union with discriminator Wenchao Xia
2013-11-14 2:46 ` [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name Wenchao Xia
2013-11-25 16:47 ` Luiz Capitulino
2013-11-28 6:19 ` Wenchao Xia
2013-11-28 14:24 ` Luiz Capitulino
2013-11-29 2:27 ` Wenchao Xia
2013-11-28 14:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529CE31A.9000300@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.