Re: [Qemu-devel] [PATCH V2 5/8] qapi script: use same function to generate enum string

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On 11/12/2013 03:25 PM, Wenchao Xia wrote:
> One function one rule, so the enum string generating have same
> behavior for different caller. If multiple caller exist for one
> enum define in schema, it is for sure the generated string is
> identical.
> 
> Note before the patch qapi-visit.py used custom function to
> generate the string in union visit, although the patch changes it,
> the final string generated is not changed. The custom function used
> before will met problem when capitalized discriminator value is
> introduced.

I'm finding this commit message awkward to read and rather wordy.  May I
suggest the shorter:

Prior to this patch, qapi-visit.py used custom code to generate enum
names used for handling a qapi union.  Fix it to instead reuse common
code, with identical generated results, and allowing future updates to
generation to only need to touch one place.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]