* [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses
@ 2013-12-02 9:16 Paolo Bonzini
2013-12-02 9:52 ` Gerd Hoffmann
2013-12-02 21:57 ` Hervé Poussineau
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2013-12-02 9:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Hervé Poussineau, kraxel
Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14)
fixed the offsets in adlib_portio_list, but forgot the matching indices
in adlib_realizefn.
Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by
"neozeed".
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/audio/adlib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
index bd8e9d9..e88d2dd 100644
--- a/hw/audio/adlib.c
+++ b/hw/audio/adlib.c
@@ -347,8 +347,8 @@ static void adlib_realizefn (DeviceState *dev, Error **errp)
s->samples = AUD_get_buffer_size_out (s->voice) >> SHIFT;
s->mixbuf = g_malloc0 (s->samples << SHIFT);
- adlib_portio_list[1].offset = s->port;
- adlib_portio_list[2].offset = s->port + 8;
+ adlib_portio_list[0].offset = s->port;
+ adlib_portio_list[1].offset = s->port + 8;
portio_list_init (port_list, OBJECT(s), adlib_portio_list, s, "adlib");
portio_list_add (port_list, isa_address_space_io(&s->parent_obj), 0);
}
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses
2013-12-02 9:16 [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses Paolo Bonzini
@ 2013-12-02 9:52 ` Gerd Hoffmann
2013-12-02 21:57 ` Hervé Poussineau
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2013-12-02 9:52 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Hervé Poussineau, qemu-devel
On Mo, 2013-12-02 at 10:16 +0100, Paolo Bonzini wrote:
> Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14)
> fixed the offsets in adlib_portio_list, but forgot the matching indices
> in adlib_realizefn.
>
> Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by
> "neozeed".
Picked into audio queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses
2013-12-02 9:16 [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses Paolo Bonzini
2013-12-02 9:52 ` Gerd Hoffmann
@ 2013-12-02 21:57 ` Hervé Poussineau
1 sibling, 0 replies; 3+ messages in thread
From: Hervé Poussineau @ 2013-12-02 21:57 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, kraxel
Paolo Bonzini a écrit :
> Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14)
> fixed the offsets in adlib_portio_list, but forgot the matching indices
> in adlib_realizefn.
>
> Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by
> "neozeed".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
Hervé
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-02 9:16 [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses Paolo Bonzini
2013-12-02 9:52 ` Gerd Hoffmann
2013-12-02 21:57 ` Hervé Poussineau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.