From: julien.grall@linaro.org (Julien Grall)
To: linux-arm-kernel@lists.infradead.org
Subject: [Xen-devel] [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64
Date: Tue, 03 Dec 2013 15:28:23 +0000 [thread overview]
Message-ID: <529DF897.1080303@linaro.org> (raw)
In-Reply-To: <529E039A02000078001097F5@nat28.tlf.novell.com>
On 12/03/2013 03:15 PM, Jan Beulich wrote:
>>>> On 03.12.13 at 16:09, Julien Grall <julien.grall@linaro.org> wrote:
>> --- a/include/xen/interface/io/blkif.h
>> +++ b/include/xen/interface/io/blkif.h
>> @@ -146,7 +146,7 @@ struct blkif_request_segment_aligned {
>> struct blkif_request_rw {
>> uint8_t nr_segments; /* number of segments */
>> blkif_vdev_t handle; /* only for read/write requests */
>> -#ifdef CONFIG_X86_64
>> +#if defined(CONFIG_X86_64) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
>
> Perhaps using
>
> #ifndef CONFIG_X86_32
>
> would be the better one, assuming that we won't add further
> non-64-bit-clean ABI variants?
I'm fine with this solution. I will resend the patch.
--
Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
patches@linaro.org, linux-arm-kernel@lists.infradead.org,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64
Date: Tue, 03 Dec 2013 15:28:23 +0000 [thread overview]
Message-ID: <529DF897.1080303@linaro.org> (raw)
In-Reply-To: <529E039A02000078001097F5@nat28.tlf.novell.com>
On 12/03/2013 03:15 PM, Jan Beulich wrote:
>>>> On 03.12.13 at 16:09, Julien Grall <julien.grall@linaro.org> wrote:
>> --- a/include/xen/interface/io/blkif.h
>> +++ b/include/xen/interface/io/blkif.h
>> @@ -146,7 +146,7 @@ struct blkif_request_segment_aligned {
>> struct blkif_request_rw {
>> uint8_t nr_segments; /* number of segments */
>> blkif_vdev_t handle; /* only for read/write requests */
>> -#ifdef CONFIG_X86_64
>> +#if defined(CONFIG_X86_64) || defined(CONFIG_ARM) || defined(CONFIG_ARM64)
>
> Perhaps using
>
> #ifndef CONFIG_X86_32
>
> would be the better one, assuming that we won't add further
> non-64-bit-clean ABI variants?
I'm fine with this solution. I will resend the patch.
--
Julien Grall
next prev parent reply other threads:[~2013-12-03 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 15:09 [PATCH] xen/block: Correctly define structures in public headers on ARM32 and ARM64 Julien Grall
2013-12-03 15:09 ` Julien Grall
2013-12-03 15:15 ` [Xen-devel] " Jan Beulich
2013-12-03 15:15 ` Jan Beulich
2013-12-03 15:28 ` Julien Grall
2013-12-03 15:28 ` Julien Grall [this message]
2013-12-03 15:28 ` [Xen-devel] " Julien Grall
2013-12-03 15:49 ` Ian Campbell
2013-12-03 15:49 ` Ian Campbell
2013-12-03 15:55 ` One Thousand Gnomes
2013-12-03 15:55 ` One Thousand Gnomes
2013-12-03 15:55 ` One Thousand Gnomes
2013-12-03 15:49 ` Ian Campbell
2013-12-03 15:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DF897.1080303@linaro.org \
--to=julien.grall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.