* [PATCH] ARM: pxa: Remove unused variables
@ 2013-12-04 10:22 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2013-12-04 10:22 UTC (permalink / raw)
To: linux-arm-kernel
The conf and of_id variables are assigned but never used, so they may as
well just be removed.
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
arch/arm/mach-pxa/irq.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
index b6cc1816463e..0eecd83c624e 100644
--- a/arch/arm/mach-pxa/irq.c
+++ b/arch/arm/mach-pxa/irq.c
@@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
{
struct device_node *node;
- const struct of_device_id *of_id;
- struct pxa_intc_conf *conf;
struct resource res;
int n, ret;
@@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
pr_err("Failed to find interrupt controller in arch-pxa\n");
return;
}
- of_id = of_match_node(intc_ids, node);
- conf = of_id->data;
ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
&pxa_internal_irq_nr);
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa: Remove unused variables
@ 2013-12-04 10:22 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2013-12-04 10:22 UTC (permalink / raw)
To: Eric Miao, Russell King, Haojian Zhuang
Cc: Daniel Mack, linux-arm-kernel, linux-kernel
The conf and of_id variables are assigned but never used, so they may as
well just be removed.
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
arch/arm/mach-pxa/irq.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
index b6cc1816463e..0eecd83c624e 100644
--- a/arch/arm/mach-pxa/irq.c
+++ b/arch/arm/mach-pxa/irq.c
@@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
{
struct device_node *node;
- const struct of_device_id *of_id;
- struct pxa_intc_conf *conf;
struct resource res;
int n, ret;
@@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
pr_err("Failed to find interrupt controller in arch-pxa\n");
return;
}
- of_id = of_match_node(intc_ids, node);
- conf = of_id->data;
ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
&pxa_internal_irq_nr);
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa: Remove unused variables
2013-12-04 10:22 ` Thierry Reding
@ 2013-12-04 10:26 ` Daniel Mack
-1 siblings, 0 replies; 6+ messages in thread
From: Daniel Mack @ 2013-12-04 10:26 UTC (permalink / raw)
To: linux-arm-kernel
On 12/04/2013 11:22 AM, Thierry Reding wrote:
> The conf and of_id variables are assigned but never used, so they may as
> well just be removed.
>
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Acked-by: Daniel Mack <zonque@gmail.com>
> ---
> arch/arm/mach-pxa/irq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index b6cc1816463e..0eecd83c624e 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
> void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
> {
> struct device_node *node;
> - const struct of_device_id *of_id;
> - struct pxa_intc_conf *conf;
> struct resource res;
> int n, ret;
>
> @@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
> pr_err("Failed to find interrupt controller in arch-pxa\n");
> return;
> }
> - of_id = of_match_node(intc_ids, node);
> - conf = of_id->data;
>
> ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
> &pxa_internal_irq_nr);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: pxa: Remove unused variables
@ 2013-12-04 10:26 ` Daniel Mack
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Mack @ 2013-12-04 10:26 UTC (permalink / raw)
To: Thierry Reding, Eric Miao, Russell King, Haojian Zhuang
Cc: linux-arm-kernel, linux-kernel
On 12/04/2013 11:22 AM, Thierry Reding wrote:
> The conf and of_id variables are assigned but never used, so they may as
> well just be removed.
>
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Acked-by: Daniel Mack <zonque@gmail.com>
> ---
> arch/arm/mach-pxa/irq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index b6cc1816463e..0eecd83c624e 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
> void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
> {
> struct device_node *node;
> - const struct of_device_id *of_id;
> - struct pxa_intc_conf *conf;
> struct resource res;
> int n, ret;
>
> @@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
> pr_err("Failed to find interrupt controller in arch-pxa\n");
> return;
> }
> - of_id = of_match_node(intc_ids, node);
> - conf = of_id->data;
>
> ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
> &pxa_internal_irq_nr);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa: Remove unused variables
2013-12-04 10:26 ` Daniel Mack
@ 2013-12-04 11:12 ` Haojian Zhuang
-1 siblings, 0 replies; 6+ messages in thread
From: Haojian Zhuang @ 2013-12-04 11:12 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 4, 2013 at 6:26 PM, Daniel Mack <zonque@gmail.com> wrote:
> On 12/04/2013 11:22 AM, Thierry Reding wrote:
>> The conf and of_id variables are assigned but never used, so they may as
>> well just be removed.
>>
>> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
>
> Acked-by: Daniel Mack <zonque@gmail.com>
>
>> ---
>> arch/arm/mach-pxa/irq.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
>> index b6cc1816463e..0eecd83c624e 100644
>> --- a/arch/arm/mach-pxa/irq.c
>> +++ b/arch/arm/mach-pxa/irq.c
>> @@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
>> void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>> {
>> struct device_node *node;
>> - const struct of_device_id *of_id;
>> - struct pxa_intc_conf *conf;
>> struct resource res;
>> int n, ret;
>>
>> @@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>> pr_err("Failed to find interrupt controller in arch-pxa\n");
>> return;
>> }
>> - of_id = of_match_node(intc_ids, node);
>> - conf = of_id->data;
>>
>> ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
>> &pxa_internal_irq_nr);
>>
>
Applied.
Thanks
Haojian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: pxa: Remove unused variables
@ 2013-12-04 11:12 ` Haojian Zhuang
0 siblings, 0 replies; 6+ messages in thread
From: Haojian Zhuang @ 2013-12-04 11:12 UTC (permalink / raw)
To: Daniel Mack
Cc: Thierry Reding, Eric Miao, Russell King,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Dec 4, 2013 at 6:26 PM, Daniel Mack <zonque@gmail.com> wrote:
> On 12/04/2013 11:22 AM, Thierry Reding wrote:
>> The conf and of_id variables are assigned but never used, so they may as
>> well just be removed.
>>
>> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
>
> Acked-by: Daniel Mack <zonque@gmail.com>
>
>> ---
>> arch/arm/mach-pxa/irq.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
>> index b6cc1816463e..0eecd83c624e 100644
>> --- a/arch/arm/mach-pxa/irq.c
>> +++ b/arch/arm/mach-pxa/irq.c
>> @@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
>> void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>> {
>> struct device_node *node;
>> - const struct of_device_id *of_id;
>> - struct pxa_intc_conf *conf;
>> struct resource res;
>> int n, ret;
>>
>> @@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>> pr_err("Failed to find interrupt controller in arch-pxa\n");
>> return;
>> }
>> - of_id = of_match_node(intc_ids, node);
>> - conf = of_id->data;
>>
>> ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
>> &pxa_internal_irq_nr);
>>
>
Applied.
Thanks
Haojian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-04 11:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-04 10:22 [PATCH] ARM: pxa: Remove unused variables Thierry Reding
2013-12-04 10:22 ` Thierry Reding
2013-12-04 10:26 ` Daniel Mack
2013-12-04 10:26 ` Daniel Mack
2013-12-04 11:12 ` Haojian Zhuang
2013-12-04 11:12 ` Haojian Zhuang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.