All of lore.kernel.org
 help / color / mirror / Atom feed
From: jonathan.austin@arm.com (Jonathan Austin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU
Date: Wed, 04 Dec 2013 16:39:43 +0000	[thread overview]
Message-ID: <529F5ACF.7010105@arm.com> (raw)
In-Reply-To: <528366A9.7060504@arm.com>

Hi all,

On 13/11/13 11:46, Jonathan Austin wrote:
> Hi Ming,
>
> On 13/11/13 11:15, Ming Lei wrote:
>> From: Jonathan Austin <jonathan.austin@arm.com>
>>
>> Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
>> we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
>>
>
> I'm not so sure about this commit message - I don't think
> it makes sense...Should it not be more like:
>
> ------->8-------
> Subject: ARM: set PAGE_OFFSET = PHYS_OFFSET if !MMU
>
> With !MMU we still set PAGE_OFFSET to 0xC0000000, which
> makes little sense and causes a regression on !MMU after
> f6537f2f0eba4eba ("scripts/kallsyms: filter symbols not
> kernel address space")
>
> This patch sets PAGE_OFFSET to PHYS_OFFSET in the !MMU
> case, fixing the regression (Tested on Cortex-R7/Vexpress)
> --------8<---------
>
> Russell: Will you pick this patch up from the list or does
> it need to go in through the patch system?


What's the status of this patch? Shall I put it in the patch system with 
the commit message above? Or is it going via someone else?

Jonny

>
> Jonny
>
>> This patch and patch 2/2 fix regression on !MMU by
>> f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
>> in kernel address space")
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>> ---
>>    arch/arm/Kconfig |    1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 799ef94..db708c4 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1560,6 +1560,7 @@ endchoice
>>
>>    config PAGE_OFFSET
>>    	hex
>> +	default PHYS_OFFSET if !MMU
>>    	default 0x40000000 if VMSPLIT_1G
>>    	default 0x80000000 if VMSPLIT_2G
>>    	default 0xC0000000
>>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Austin <jonathan.austin@arm.com>
To: Jonathan Austin <jonathan.austin@arm.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU
Date: Wed, 04 Dec 2013 16:39:43 +0000	[thread overview]
Message-ID: <529F5ACF.7010105@arm.com> (raw)
In-Reply-To: <528366A9.7060504@arm.com>

Hi all,

On 13/11/13 11:46, Jonathan Austin wrote:
> Hi Ming,
>
> On 13/11/13 11:15, Ming Lei wrote:
>> From: Jonathan Austin <jonathan.austin@arm.com>
>>
>> Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
>> we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
>>
>
> I'm not so sure about this commit message - I don't think
> it makes sense...Should it not be more like:
>
> ------->8-------
> Subject: ARM: set PAGE_OFFSET = PHYS_OFFSET if !MMU
>
> With !MMU we still set PAGE_OFFSET to 0xC0000000, which
> makes little sense and causes a regression on !MMU after
> f6537f2f0eba4eba ("scripts/kallsyms: filter symbols not
> kernel address space")
>
> This patch sets PAGE_OFFSET to PHYS_OFFSET in the !MMU
> case, fixing the regression (Tested on Cortex-R7/Vexpress)
> --------8<---------
>
> Russell: Will you pick this patch up from the list or does
> it need to go in through the patch system?


What's the status of this patch? Shall I put it in the patch system with 
the commit message above? Or is it going via someone else?

Jonny

>
> Jonny
>
>> This patch and patch 2/2 fix regression on !MMU by
>> f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
>> in kernel address space")
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>> ---
>>    arch/arm/Kconfig |    1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 799ef94..db708c4 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1560,6 +1560,7 @@ endchoice
>>
>>    config PAGE_OFFSET
>>    	hex
>> +	default PHYS_OFFSET if !MMU
>>    	default 0x40000000 if VMSPLIT_1G
>>    	default 0x80000000 if VMSPLIT_2G
>>    	default 0xC0000000
>>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>



  parent reply	other threads:[~2013-12-04 16:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 11:15 [PATCH 0/2] ARM & scripts: fix kallsyms regression Ming Lei
2013-11-13 11:15 ` Ming Lei
2013-11-13 11:15 ` [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU Ming Lei
2013-11-13 11:15   ` Ming Lei
2013-11-13 11:46   ` Jonathan Austin
2013-11-13 11:46     ` Jonathan Austin
2013-11-13 13:39     ` Uwe Kleine-König
2013-11-13 13:39       ` Uwe Kleine-König
2013-11-13 13:39       ` Uwe Kleine-König
2013-12-04 16:39     ` Jonathan Austin [this message]
2013-12-04 16:39       ` Jonathan Austin
2013-11-13 11:15 ` [PATCH 2/2] scripts/link-vmlinux.sh: only filter kernel symbols for arm Ming Lei
2013-11-13 11:15   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529F5ACF.7010105@arm.com \
    --to=jonathan.austin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.