From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, yung-chuan.liao@linux.intel.com,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
venkataprasad.potturu@amd.com, Syed.SabaKareem@amd.com,
Mario.Limonciello@amd.com, Richard.Gong@amd.com,
Poojitha.N@amd.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v3 02/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire DAI link support
Date: Thu, 29 Oct 2026 09:07:23 +0100 [thread overview]
Message-ID: <529b2b8a-fc6b-435e-a7ac-e73bf4eec729@linux.dev> (raw)
In-Reply-To: <a5771999-6521-4d02-868a-5cf5b75b6848@amd.com>
On 10/29/26 05:56, Mukunda,Vijendar wrote:
> On 26/10/26 02:41, Pierre-Louis Bossart wrote:
>> It'd be useful to comment/explain why this routine only relies on a
>> subset of IDS...
> On ACP7x, each SoundWire data port has a dedicated DMA channel mapped
> in hardware. This function selects only the ports required by the
> currently supported ACP7x machine topologies:
>
> AUDIO0_TX (0) - headset/jack playback
> AUDIO4_TX (4) - amplifier/speaker playback
> AUDIO0_RX (11) - headset/jack capture
> AUDIO4_RX (15) - amplifier/speaker capture (feedback)
> AUDIO5_RX (16) - DMIC capture
>
> The remaining port IDs are defined for completeness to represent the
> hardware data port layout, but are not used by the currently supported
> machine topologies.
>
> The ID numbering differs from ACP70 due to the hardware differences
> between ACP70 and ACP7x. ACP7x uses a flat ID space, with TX ports
> numbered 0-10 and RX ports numbered 11-21.
>
> Will add comments above the define block and the function to clarify
> this in the next version.
sounds good, thank you.
next prev parent reply other threads:[~2026-10-29 8:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 6:50 [PATCH v3 00/13] ASoC: amd: acp: ACP7.B/7.F SoundWire machine driver support Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 01/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire link count for machine driver Vijendar Mukunda
2026-10-25 20:59 ` Pierre-Louis Bossart
2026-10-29 3:45 ` Mukunda,Vijendar
2026-10-23 6:50 ` [PATCH v3 02/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire DAI link support Vijendar Mukunda
2026-10-25 21:11 ` Pierre-Louis Bossart
2026-10-29 4:56 ` Mukunda,Vijendar
2026-10-29 8:07 ` Pierre-Louis Bossart [this message]
2026-10-23 6:50 ` [PATCH v3 03/13] ASoC: amd: acp: add PDM controller selection for ACP7.B/7.F SoundWire machine driver Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 04/13] ASoC: amd: acp: log ASOC_SDW_ACP_DMIC1 quirk in SOF " Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 05/13] ASoC: amd: acp: enable DMIC DAI link based on PDM controller selection Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 06/13] ASoC: amd: acp: move ignore_internal_dmic gate to DMIC enable condition Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 07/13] ASoC: amd: acp: add DMIC components string for SOF SoundWire machine driver Vijendar Mukunda
2026-10-23 7:10 ` sashiko-bot
2026-10-23 8:10 ` Mukunda,Vijendar
2026-10-23 6:50 ` [PATCH v3 08/13] ASoC: amd: acp: set PCI subsystem ID " Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 09/13] ASoC: amd: acp: fix MODULE_AUTHOR missing closing angle bracket Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 10/13] ASoC: amd: acp: add ACPI machine tables for ACP7.F SoundWire Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 11/13] ASoC: SOF: amd: add alt_machines for ACP7.F SOF SoundWire Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 12/13] ASoC: amd: acp: add SoundWire machine table for ACP7.B platform Vijendar Mukunda
2026-10-23 6:50 ` [PATCH v3 13/13] ASoC: SOF: amd: register SoundWire alt_machines for ACP7.B Vijendar Mukunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529b2b8a-fc6b-435e-a7ac-e73bf4eec729@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Poojitha.N@amd.com \
--cc=Richard.Gong@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vijendar.mukunda@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.