Re: [PATCH v3 07/13] ASoC: amd: acp: add DMIC components string for SOF SoundWire machine driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ASoC: amd: acp: missing asoc_sdw_mc_dailink_exit_loop() in mc_probe()
--

commit 418fccdf2ffaf02e2c03c094859e73443fbe31c7
Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

ASoC: amd: acp: add DMIC components string for SOF SoundWire machine driver

This commit appends the DMIC component and mic count string to
card->components in mc_probe() when a DMIC DAI link is created by
sof_card_dai_links_create().

> diff --git a/sound/soc/amd/acp/acp-sdw-sof-mach.c b/sound/soc/amd/acp/acp-sdw-sof-mach.c
> index 5c201d0b3bef9..4c171e52410a6 100644
> --- a/sound/soc/amd/acp/acp-sdw-sof-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-sof-mach.c

[ ... ]

> @@ -489,6 +489,17 @@ static int mc_probe(struct platform_device *pdev)
>  	if (!card->components)
>  		return -ENOMEM;
>  
> +	if ((sof_sdw_quirk & ASOC_SDW_ACP_DMIC || mach->mach_params.dmic_num ||
> +	     amd_ctx->pdm_sel) && !ctx->ignore_internal_dmic) {
> +		dmic_num = mach->mach_params.dmic_num ? mach->mach_params.dmic_num : 1;
> +		card->components = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> +						  "%s mic:acp-dmic cfg-mics:%d",
> +						  card->components,
> +						  dmic_num);
> +		if (!card->components)
> +			return -ENOMEM;
> +	}

[Severity: Medium]
If devm_kasprintf() fails here (as well as in the preceding allocation for
cfg-amp), does returning -ENOMEM directly leak the SoundWire codec device
references and software nodes initialized during sof_card_dai_links_create()?

Earlier in sound/soc/amd/acp/acp-sdw-sof-mach.c:mc_probe(),
sof_card_dai_links_create() invokes the endpoint .init callbacks via
create_sdw_dailinks() -> create_sdw_dailink(), such as
sound/soc/sdw_utils/soc_sdw_rt711.c:asoc_sdw_rt711_init():

	sdw_dev = bus_find_device_by_name(&sdw_bus_type, NULL, dai_links->codecs[0].name);
	if (!sdw_dev)
		return -EPROBE_DEFER;

	ret = rt711_add_codec_device_props(sdw_dev, ctx->mc_quirk);
	if (ret < 0) {
		put_device(sdw_dev);
		return ret;
	}
	ctx->headset_codec_dev = sdw_dev;

When devm_snd_soc_register_card() fails right below in mc_probe(), it cleans
these up with asoc_sdw_mc_dailink_exit_loop(card):

	ret = devm_snd_soc_register_card(&pdev->dev, card);
	if (ret) {
		dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed %d\n", ret);
		asoc_sdw_mc_dailink_exit_loop(card);
		return ret;
	}

Should the devm_kasprintf() failure path also call
asoc_sdw_mc_dailink_exit_loop(card) before returning -ENOMEM?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023065216.3473883-1-Vijendar.Mukunda@amd.com?part=7