From: Laxman Dewangan <ldewangan@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"len.brown@intel.com" <len.brown@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"heiko@sntech.de" <heiko@sntech.de>,
"pavel@ucw.cz" <pavel@ucw.cz>,
Stephen Warren <swarren@wwwdotorg.org>"Rafael J. Wysocki"
<rjw@rjwysocki.net>
Subject: Re: [REPOST PATCH V2] irq: enable all irqs unconditionally in irq_resume
Date: Thu, 5 Dec 2013 16:19:05 +0530 [thread overview]
Message-ID: <52A05A21.5070100@nvidia.com> (raw)
In-Reply-To: <1385388587-16442-1-git-send-email-ldewangan@nvidia.com>
Hi Thomas,
On Monday 25 November 2013 07:39 PM, Laxman Dewangan wrote:
> When system enters into suspend, it disable all irqs in single
> function call. This disables EARLY_RESUME irqs also along with
> normal irqs.
>
> The EARLY_RESUME irqs get enabled in sys_core_ops->resume and
> non-EARLY_RESUME irqs get enabled in normal system resume path.
>
> When suspend_noirq failed or suspend is aborted for any reason,
> the EARLY_RESUME irqs do not get enabled as sys_core_ops->resume()
> call did not happen. It only enables the non-EARLY_RESUME irqs in normal
> disable for remaining life of system.
>
> Enable all irqs unconditionally in normal irq_resume() regardless of
> EARLY_RESUME irqs have been already enabled or not.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Acked-by-and-tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
>
Can you please review this patch?
This patch is pending from long back for review.
Thanks,
Laxman
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"len.brown@intel.com" <len.brown@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"heiko@sntech.de" <heiko@sntech.de>,
"pavel@ucw.cz" <pavel@ucw.cz>,
Stephen Warren <swarren@wwwdotorg.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [REPOST PATCH V2] irq: enable all irqs unconditionally in irq_resume
Date: Thu, 5 Dec 2013 16:19:05 +0530 [thread overview]
Message-ID: <52A05A21.5070100@nvidia.com> (raw)
In-Reply-To: <1385388587-16442-1-git-send-email-ldewangan@nvidia.com>
Hi Thomas,
On Monday 25 November 2013 07:39 PM, Laxman Dewangan wrote:
> When system enters into suspend, it disable all irqs in single
> function call. This disables EARLY_RESUME irqs also along with
> normal irqs.
>
> The EARLY_RESUME irqs get enabled in sys_core_ops->resume and
> non-EARLY_RESUME irqs get enabled in normal system resume path.
>
> When suspend_noirq failed or suspend is aborted for any reason,
> the EARLY_RESUME irqs do not get enabled as sys_core_ops->resume()
> call did not happen. It only enables the non-EARLY_RESUME irqs in normal
> disable for remaining life of system.
>
> Enable all irqs unconditionally in normal irq_resume() regardless of
> EARLY_RESUME irqs have been already enabled or not.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Acked-by-and-tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
>
Can you please review this patch?
This patch is pending from long back for review.
Thanks,
Laxman
next prev parent reply other threads:[~2013-12-05 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:09 [REPOST PATCH V2] irq: enable all irqs unconditionally in irq_resume Laxman Dewangan
2013-11-25 14:09 ` Laxman Dewangan
2013-11-25 21:28 ` [tip:irq/urgent] irq: Enable " tip-bot for Laxman Dewangan
2013-12-05 10:49 ` Laxman Dewangan [this message]
2013-12-05 10:49 ` [REPOST PATCH V2] irq: enable " Laxman Dewangan
2013-12-05 11:01 ` Heiko Stübner
2013-12-05 11:07 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A05A21.5070100@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ian.campbell@citrix.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.