From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Genmai SPI over GPIO support
Date: Thu, 05 Dec 2013 12:20:06 +0000 [thread overview]
Message-ID: <52A06F76.1010105@cogentembedded.com> (raw)
In-Reply-To: <20131204212915.24243.27225.sendpatchset@w520>
Hello.
On 05-12-2013 1:29, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> Hook up the serial flash memory to bit bang SPI on the Genmai board.
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> Written on to of renesas git tag renesas-devel-v3.13-rc2-20131202 and
> [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support
> arch/arm/boot/dts/r7s72100-genmai-reference.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> --- 0010/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> +++ work/arch/arm/boot/dts/r7s72100-genmai-reference.dts 2013-12-05 06:23:57.000000000 +0900
> @@ -56,5 +56,20 @@
> reg = <0x50>;
> };
> };
> + spi0 {
Maybe just "spi"?
> + compatible = "spi-gpio";
> + gpio-sck = <&port9 2 0>;
> + gpio-mosi = <&port9 4 0>;
> + gpio-miso = <&port9 5 0>;
> + cs-gpios = <&port9 3 0>;
> + num-chipselects = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> + s25fl512s: s25fl512s0 {
The node should probably be named "flash", according to ePAPR spec. And
why you didn't specify "@0"?
> + compatible = "s25fl512s";
> + reg = <0>;
> + spi-max-frequency = <104000000>;
> + };
> + };
> };
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: Genmai SPI over GPIO support
Date: Thu, 05 Dec 2013 16:20:06 +0400 [thread overview]
Message-ID: <52A06F76.1010105@cogentembedded.com> (raw)
In-Reply-To: <20131204212915.24243.27225.sendpatchset@w520>
Hello.
On 05-12-2013 1:29, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> Hook up the serial flash memory to bit bang SPI on the Genmai board.
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> Written on to of renesas git tag renesas-devel-v3.13-rc2-20131202 and
> [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support
> arch/arm/boot/dts/r7s72100-genmai-reference.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> --- 0010/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> +++ work/arch/arm/boot/dts/r7s72100-genmai-reference.dts 2013-12-05 06:23:57.000000000 +0900
> @@ -56,5 +56,20 @@
> reg = <0x50>;
> };
> };
> + spi0 {
Maybe just "spi"?
> + compatible = "spi-gpio";
> + gpio-sck = <&port9 2 0>;
> + gpio-mosi = <&port9 4 0>;
> + gpio-miso = <&port9 5 0>;
> + cs-gpios = <&port9 3 0>;
> + num-chipselects = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> + s25fl512s: s25fl512s0 {
The node should probably be named "flash", according to ePAPR spec. And
why you didn't specify "@0"?
> + compatible = "s25fl512s";
> + reg = <0>;
> + spi-max-frequency = <104000000>;
> + };
> + };
> };
WBR, Sergei
next prev parent reply other threads:[~2013-12-05 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 21:29 [PATCH] ARM: shmobile: Genmai SPI over GPIO support Magnus Damm
2013-12-04 21:29 ` Magnus Damm
2013-12-04 22:54 ` Laurent Pinchart
2013-12-04 22:54 ` Laurent Pinchart
2013-12-05 12:20 ` Sergei Shtylyov [this message]
2013-12-05 12:20 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A06F76.1010105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.