[PATCH 1/2] sched/numa: fix set cpupid on page migration twice

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/2] sched/numa: fix set cpupid on page migration twice
@ 2013-12-05 11:10 ` Wanpeng Li
  0 siblings, 0 replies; 9+ messages in thread
From: Wanpeng Li @ 2013-12-05 11:10 UTC (permalink / raw)
  To: Ingo Molnar, Andrew Morton
  Cc: Peter Zijlstra, Mel Gorman, Rik van Riel, Naoya Horiguchi,
	linux-kernel, linux-mm, Wanpeng Li

commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over 
the cpupid at page migration time, there is unnecessary to set it again 
in migrate_misplaced_transhuge_page, this patch fix it.

Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 mm/migrate.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index bb94004..fdb70f7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1736,8 +1736,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
 	if (!new_page)
 		goto out_fail;
 
-	page_cpupid_xchg_last(new_page, page_cpupid_last(page));
-
 	isolated = numamigrate_isolate_page(pgdat, page);
 	if (!isolated) {
 		put_page(new_page);
-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 1/2] sched/numa: fix set cpupid on page migration twice
@ 2013-12-05 11:10 ` Wanpeng Li
  0 siblings, 0 replies; 9+ messages in thread
From: Wanpeng Li @ 2013-12-05 11:10 UTC (permalink / raw)
  To: Ingo Molnar, Andrew Morton
  Cc: Peter Zijlstra, Mel Gorman, Rik van Riel, Naoya Horiguchi,
	linux-kernel, linux-mm, Wanpeng Li

commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over 
the cpupid at page migration time, there is unnecessary to set it again 
in migrate_misplaced_transhuge_page, this patch fix it.

Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 mm/migrate.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index bb94004..fdb70f7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1736,8 +1736,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
 	if (!new_page)
 		goto out_fail;
 
-	page_cpupid_xchg_last(new_page, page_cpupid_last(page));
-
 	isolated = numamigrate_isolate_page(pgdat, page);
 	if (!isolated) {
 		put_page(new_page);
-- 
1.7.7.6


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct
  2013-12-05 11:10 ` Wanpeng Li
@ 2013-12-05 11:10   ` Wanpeng Li
  -1 siblings, 0 replies; 9+ messages in thread
From: Wanpeng Li @ 2013-12-05 11:10 UTC (permalink / raw)
  To: Ingo Molnar, Andrew Morton
  Cc: Peter Zijlstra, Mel Gorman, Rik van Riel, Naoya Horiguchi,
	linux-kernel, linux-mm, Wanpeng Li

Drop unused idx field of task_numa_env struct.

Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 kernel/sched/fair.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fd773ad..ea3fd1e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1037,7 +1037,7 @@ struct task_numa_env {
 
 	struct numa_stats src_stats, dst_stats;
 
-	int imbalance_pct, idx;
+	int imbalance_pct;
 
 	struct task_struct *best_task;
 	long best_imp;
-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct
@ 2013-12-05 11:10   ` Wanpeng Li
  0 siblings, 0 replies; 9+ messages in thread
From: Wanpeng Li @ 2013-12-05 11:10 UTC (permalink / raw)
  To: Ingo Molnar, Andrew Morton
  Cc: Peter Zijlstra, Mel Gorman, Rik van Riel, Naoya Horiguchi,
	linux-kernel, linux-mm, Wanpeng Li

Drop unused idx field of task_numa_env struct.

Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
---
 kernel/sched/fair.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fd773ad..ea3fd1e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1037,7 +1037,7 @@ struct task_numa_env {
 
 	struct numa_stats src_stats, dst_stats;
 
-	int imbalance_pct, idx;
+	int imbalance_pct;
 
 	struct task_struct *best_task;
 	long best_imp;
-- 
1.7.7.6


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct
  2013-12-05 11:10   ` Wanpeng Li
@ 2013-12-05 12:27     ` Rik van Riel
  -1 siblings, 0 replies; 9+ messages in thread
From: Rik van Riel @ 2013-12-05 12:27 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: Ingo Molnar, Andrew Morton, Peter Zijlstra, Mel Gorman,
	Naoya Horiguchi, linux-kernel, linux-mm

On 12/05/2013 06:10 AM, Wanpeng Li wrote:
> Drop unused idx field of task_numa_env struct.
> 
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct
@ 2013-12-05 12:27     ` Rik van Riel
  0 siblings, 0 replies; 9+ messages in thread
From: Rik van Riel @ 2013-12-05 12:27 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: Ingo Molnar, Andrew Morton, Peter Zijlstra, Mel Gorman,
	Naoya Horiguchi, linux-kernel, linux-mm

On 12/05/2013 06:10 AM, Wanpeng Li wrote:
> Drop unused idx field of task_numa_env struct.
> 
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct
  2013-12-05 11:10   ` Wanpeng Li
@ 2013-12-05 15:03     ` Naoya Horiguchi
  -1 siblings, 0 replies; 9+ messages in thread
From: Naoya Horiguchi @ 2013-12-05 15:03 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: Ingo Molnar, Andrew Morton, Peter Zijlstra, Mel Gorman,
	Rik van Riel, linux-kernel, linux-mm

On Thu, Dec 05, 2013 at 07:10:17PM +0800, Wanpeng Li wrote:
> Drop unused idx field of task_numa_env struct.
> 
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  kernel/sched/fair.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index fd773ad..ea3fd1e 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1037,7 +1037,7 @@ struct task_numa_env {
>  
>  	struct numa_stats src_stats, dst_stats;
>  
> -	int imbalance_pct, idx;
> +	int imbalance_pct;
>  
>  	struct task_struct *best_task;
>  	long best_imp;
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct
@ 2013-12-05 15:03     ` Naoya Horiguchi
  0 siblings, 0 replies; 9+ messages in thread
From: Naoya Horiguchi @ 2013-12-05 15:03 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: Ingo Molnar, Andrew Morton, Peter Zijlstra, Mel Gorman,
	Rik van Riel, linux-kernel, linux-mm

On Thu, Dec 05, 2013 at 07:10:17PM +0800, Wanpeng Li wrote:
> Drop unused idx field of task_numa_env struct.
> 
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  kernel/sched/fair.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index fd773ad..ea3fd1e 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1037,7 +1037,7 @@ struct task_numa_env {
>  
>  	struct numa_stats src_stats, dst_stats;
>  
> -	int imbalance_pct, idx;
> +	int imbalance_pct;
>  
>  	struct task_struct *best_task;
>  	long best_imp;
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [tip:sched/core] sched/numa: Drop idx field of task_numa_env struct
  2013-12-05 11:10   ` Wanpeng Li
                     ` (2 preceding siblings ...)
  (?)
@ 2013-12-10  9:22   ` tip-bot for Wanpeng Li
  -1 siblings, 0 replies; 9+ messages in thread
From: tip-bot for Wanpeng Li @ 2013-12-10  9:22 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, liwanp, peterz, n-horiguchi, riel,
	mgorman, tglx

Commit-ID:  40ea2b42d7c44386cf81d5636d574193da2c8df2
Gitweb:     http://git.kernel.org/tip/40ea2b42d7c44386cf81d5636d574193da2c8df2
Author:     Wanpeng Li <liwanp@linux.vnet.ibm.com>
AuthorDate: Thu, 5 Dec 2013 19:10:17 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 5 Dec 2013 13:38:36 +0100

sched/numa: Drop idx field of task_numa_env struct

Drop unused idx field of task_numa_env struct.

Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/1386241817-5051-2-git-send-email-liwanp@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a566c07..49aa01f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1037,7 +1037,7 @@ struct task_numa_env {
 
 	struct numa_stats src_stats, dst_stats;
 
-	int imbalance_pct, idx;
+	int imbalance_pct;
 
 	struct task_struct *best_task;
 	long best_imp;

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-12-10  9:23 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-05 11:10 [PATCH 1/2] sched/numa: fix set cpupid on page migration twice Wanpeng Li
2013-12-05 11:10 ` Wanpeng Li
2013-12-05 11:10 ` [PATCH 2/2] sched/numa: drop idx field of task_numa_env struct Wanpeng Li
2013-12-05 11:10   ` Wanpeng Li
2013-12-05 12:27   ` Rik van Riel
2013-12-05 12:27     ` Rik van Riel
2013-12-05 15:03   ` Naoya Horiguchi
2013-12-05 15:03     ` Naoya Horiguchi
2013-12-10  9:22   ` [tip:sched/core] sched/numa: Drop " tip-bot for Wanpeng Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.