All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 next 3/4] batman-adv: fix size of batadv_icmp_header
Date: Thu, 05 Dec 2013 15:30:12 +0100	[thread overview]
Message-ID: <52A08DF4.3020604@meshcoding.com> (raw)
In-Reply-To: <1386253212-998-1-git-send-email-antonio@meshcoding.com>

On 05/12/13 15:20, Antonio Quartulli wrote:

>  struct batadv_icmp_header {
>  	uint8_t  packet_type;
>  	uint8_t  version;
>  	uint8_t  ttl;
> -	uint8_t  msg_type; /* see ICMP message types above */

I think we should keep this comment. I'm going to send v3.

Cheers,

> +	uint8_t  msg_type;
>  	uint8_t  dst[ETH_ALEN];
>  	uint8_t  orig[ETH_ALEN];
>  	uint8_t  uid;
> +	uint8_t  align[3];
>  };

-- 
Antonio Quartulli

  reply	other threads:[~2013-12-05 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 19:38 [B.A.T.M.A.N.] [PATCH-next 1/4] batman-adv: fix alignment for batadv_coded_packet Simon Wunderlich
2013-12-02 19:38 ` [B.A.T.M.A.N.] [PATCH-next 2/4] batman-adv: fix header alignment by unrolling batadv_header Simon Wunderlich
2013-12-12  5:44   ` Marek Lindner
2013-12-02 19:38 ` [B.A.T.M.A.N.] [PATCH-next 3/4] batman-adv: fix size of batadv_icmp_header Simon Wunderlich
2013-12-02 20:16   ` Antonio Quartulli
2013-12-03 10:54     ` Simon Wunderlich
2013-12-05  1:00       ` Antonio Quartulli
2013-12-05 14:20         ` [B.A.T.M.A.N.] [PATCHv2 next " Antonio Quartulli
2013-12-05 14:30           ` Antonio Quartulli [this message]
2013-12-02 19:38 ` [B.A.T.M.A.N.] [PATCH-next 4/4] batman-adv: fix size of batadv_bla_claim_dst Simon Wunderlich
2013-12-14  9:43   ` Marek Lindner
2013-12-12  5:42 ` [B.A.T.M.A.N.] [PATCH-next 1/4] batman-adv: fix alignment for batadv_coded_packet Marek Lindner
2013-12-15 15:38 ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A08DF4.3020604@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.