From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH-next 2/4] batman-adv: fix header alignment by unrolling batadv_header
Date: Thu, 12 Dec 2013 13:44:19 +0800 [thread overview]
Message-ID: <7685347.MVhl80WSVP@diderot> (raw)
In-Reply-To: <1386013113-25471-2-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
On Monday 02 December 2013 20:38:31 Simon Wunderlich wrote:
> The size of the batadv_header of 3 is problematic on some architectures
> which automatically pad all structures to a 32 bit boundary. To not lose
> performance by packing this struct, better embed it into the various
> host structures.
>
> Reported-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> ---
> bat_iv_ogm.c | 36 +++++++++++------------
> distributed-arp-table.c | 6 ++--
> fragmentation.c | 8 ++---
> icmp_socket.c | 6 ++--
> main.c | 12 ++++----
> network-coding.c | 22 +++++++-------
> packet.h | 74
> +++++++++++++++++++++++++++++++++--------------
> routing.c | 18 ++++++------
> send.c | 10 +++----
> soft-interface.c | 11 +++----
> 10 files changed, 118 insertions(+), 85 deletions(-)
Applied in revision 31f0d40.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-12-12 5:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 19:38 [B.A.T.M.A.N.] [PATCH-next 1/4] batman-adv: fix alignment for batadv_coded_packet Simon Wunderlich
2013-12-02 19:38 ` [B.A.T.M.A.N.] [PATCH-next 2/4] batman-adv: fix header alignment by unrolling batadv_header Simon Wunderlich
2013-12-12 5:44 ` Marek Lindner [this message]
2013-12-02 19:38 ` [B.A.T.M.A.N.] [PATCH-next 3/4] batman-adv: fix size of batadv_icmp_header Simon Wunderlich
2013-12-02 20:16 ` Antonio Quartulli
2013-12-03 10:54 ` Simon Wunderlich
2013-12-05 1:00 ` Antonio Quartulli
2013-12-05 14:20 ` [B.A.T.M.A.N.] [PATCHv2 next " Antonio Quartulli
2013-12-05 14:30 ` Antonio Quartulli
2013-12-02 19:38 ` [B.A.T.M.A.N.] [PATCH-next 4/4] batman-adv: fix size of batadv_bla_claim_dst Simon Wunderlich
2013-12-14 9:43 ` Marek Lindner
2013-12-12 5:42 ` [B.A.T.M.A.N.] [PATCH-next 1/4] batman-adv: fix alignment for batadv_coded_packet Marek Lindner
2013-12-15 15:38 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7685347.MVhl80WSVP@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.