From: Stefan Weil <sw@weilnetz.de>
To: Don Slutz <dslutz@verizon.com>, Anthony Liguori <aliguori@amazon.com>
Cc: "Laurent Desnogues" <laurent.desnogues@gmail.com>,
"Marc-André Lureau" <mlureau@redhat.com>,
"Alon Levy" <alevy@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation for older versions of glib (bug #1258168)
Date: Thu, 05 Dec 2013 19:45:05 +0100 [thread overview]
Message-ID: <52A0C9B1.1050408@weilnetz.de> (raw)
In-Reply-To: <52A0BFFC.3030808@terremark.com>
Am 05.12.2013 19:03, schrieb Don Slutz:
> On 12/05/13 12:24, Stefan Weil wrote:
[...]
>> @@ -760,7 +760,7 @@ main(
>> g_io_channel_unref(channel_stdin);
>> g_io_channel_unref(channel_socket);
>> - g_byte_array_unref(socket_to_send);
>> + g_byte_array_free(socket_to_send);
>>
> This fails with:
>
> /home/don/qemu/libcacard/vscclient.c: In function 'main':
> /home/don/qemu/libcacard/vscclient.c:763: error: too few arguments to
> function 'g_byte_array_free'
> make: *** [libcacard/vscclient.o] Error 1
>
> The bug included ", TRUE"...
> -Don Slutz
>> closesocket(sock);
>> return 0;
>
Sorry, I should have waited until the compile test was finished before
sending this patch.
v2 with fixed commit message and fixed call of g_byte_array was sent a
minute ago.
Stefan Weil
prev parent reply other threads:[~2013-12-05 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 17:24 [Qemu-devel] [PATCH] libcacard: Fix compilation for older versions of glib (bug #1258168) Stefan Weil
2013-12-05 17:27 ` Stefan Weil
2013-12-05 18:03 ` Don Slutz
2013-12-05 18:45 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A0C9B1.1050408@weilnetz.de \
--to=sw@weilnetz.de \
--cc=alevy@redhat.com \
--cc=aliguori@amazon.com \
--cc=dslutz@verizon.com \
--cc=laurent.desnogues@gmail.com \
--cc=mlureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.