From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Fainelli <florian@openwrt.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, grant.likely@linaro.org,
devicetree@vger.kernel.org, abrodkin@synopsys.com,
rob.herring@calxeda.com, mark.rutland@arm.com,
sebastian.hesselbarth@gmail.com,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH 3/7] net: of_mdio: do not overwrite PHY interrupt configuration
Date: Fri, 06 Dec 2013 03:45:04 +0300 [thread overview]
Message-ID: <52A11E10.5080909@cogentembedded.com> (raw)
In-Reply-To: <1386283936-26104-4-git-send-email-florian@openwrt.org>
Hello.
On 12/06/2013 01:52 AM, Florian Fainelli wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> If irq_of_parse_and_map fails to find an interrupt line for a given PHY,
> we will force the PHY interrupt to be PHY_POLL, completely overriding
> the previous value that the MDIO bus may have set for us (e.g:
> PHY_IGNORE_INTERRUPT). In case of failure, just restore the previous
> value.
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/of/of_mdio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index f93ebca..4923ab2 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
[...]
> @@ -37,10 +37,11 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
> return 1;
>
> if (mdio->irq) {
> + prev_irq= mdio->irq[addr];
You forgot space before =.
WBR, Sergei
next prev parent reply other threads:[~2013-12-06 0:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 22:52 [PATCH 0/7] net: of_mdio improvements Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-05 22:52 ` [PATCH 1/7] net: of_mdio: factor PHY registration from of_mdiobus_register Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-08 16:00 ` Rob Herring
[not found] ` <1386283936-26104-1-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-12-05 22:52 ` [PATCH 2/7] net: of_mdio: use PHY_MAX_ADDR constant Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-11 13:52 ` Grant Likely
2013-12-05 22:52 ` [PATCH 3/7] net: of_mdio: do not overwrite PHY interrupt configuration Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-06 0:45 ` Sergei Shtylyov [this message]
2013-12-11 13:57 ` Grant Likely
2013-12-05 22:52 ` [PATCH 4/7] net: phy: breakdown PHY_*_FEATURES defines Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-05 22:52 ` [PATCH 5/7] net: of_mdio: parse "max-speed" property to set PHY supported features Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-06 0:49 ` Sergei Shtylyov
2013-12-05 23:53 ` Florian Fainelli
2013-12-06 0:03 ` Joe Perches
2013-12-06 0:47 ` David Miller
2013-12-08 15:51 ` Rob Herring
2013-12-11 14:02 ` Grant Likely
2013-12-05 22:52 ` [PATCH 6/7] arc_emac: remove custom "max-speed" parsing code Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-05 22:52 ` [PATCH 7/7] Documentation: update Ethernet PHY devices binding with 'max-speed' Florian Fainelli
2013-12-05 22:52 ` Florian Fainelli
2013-12-06 19:57 ` [PATCH 0/7] net: of_mdio improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A11E10.5080909@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=abrodkin@synopsys.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian@openwrt.org \
--cc=grant.likely@linaro.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.