From: Wang Weidong <wangweidong1@huawei.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v4] sctp: check the rto_min and rto_max
Date: Fri, 06 Dec 2013 10:36:45 +0000 [thread overview]
Message-ID: <52A1A8BD.6040502@huawei.com> (raw)
In-Reply-To: <52A19DF6.1080808@redhat.com>
On 2013/12/6 17:50, Daniel Borkmann wrote:
> On 12/06/2013 09:48 AM, Wang Weidong wrote:
>
>> Should I define it in net/sctp/sctp.h, so sysctl.c can use it as well.
>> Or I just define it in the socket.c same as the definition in sysctl.c?
>
> Preferably in include/net/sctp/constants.h where we already have most
> other constants anyway.
>
>
Hi Daniel,
in sysctl.c it will use a point to the value while the socket.c use the value.
So if I define macros SCTP_ONE or SCTP_TIMER_MAX in include/net/sctp/constants.h
which only used by socket.c. Is it OK?
Regards.
Wang
WARNING: multiple messages have this Message-ID (diff)
From: Wang Weidong <wangweidong1@huawei.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-sctp@vger.kernel.org>
Subject: Re: [PATCH v4] sctp: check the rto_min and rto_max
Date: Fri, 6 Dec 2013 18:36:45 +0800 [thread overview]
Message-ID: <52A1A8BD.6040502@huawei.com> (raw)
In-Reply-To: <52A19DF6.1080808@redhat.com>
On 2013/12/6 17:50, Daniel Borkmann wrote:
> On 12/06/2013 09:48 AM, Wang Weidong wrote:
>
>> Should I define it in net/sctp/sctp.h, so sysctl.c can use it as well.
>> Or I just define it in the socket.c same as the definition in sysctl.c?
>
> Preferably in include/net/sctp/constants.h where we already have most
> other constants anyway.
>
>
Hi Daniel,
in sysctl.c it will use a point to the value while the socket.c use the value.
So if I define macros SCTP_ONE or SCTP_TIMER_MAX in include/net/sctp/constants.h
which only used by socket.c. Is it OK?
Regards.
Wang
next prev parent reply other threads:[~2013-12-06 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 2:19 [PATCH v4] sctp: check the rto_min and rto_max Wang Weidong
2013-12-05 2:19 ` Wang Weidong
2013-12-05 13:32 ` Neil Horman
2013-12-05 13:32 ` Neil Horman
2013-12-05 14:07 ` Wang Weidong
2013-12-05 14:07 ` Wang Weidong
2013-12-05 16:25 ` Daniel Borkmann
2013-12-05 16:25 ` Daniel Borkmann
2013-12-06 1:23 ` Wang Weidong
2013-12-06 1:23 ` Wang Weidong
2013-12-06 8:54 ` Daniel Borkmann
2013-12-06 8:54 ` Daniel Borkmann
2013-12-06 8:48 ` Wang Weidong
2013-12-06 8:48 ` Wang Weidong
2013-12-06 9:50 ` Daniel Borkmann
2013-12-06 9:50 ` Daniel Borkmann
2013-12-06 9:52 ` Wang Weidong
2013-12-06 9:52 ` Wang Weidong
2013-12-06 10:36 ` Wang Weidong [this message]
2013-12-06 10:36 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1A8BD.6040502@huawei.com \
--to=wangweidong1@huawei.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.