From: "H. Peter Anvin" <hpa@zytor.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Qiaowei Ren <qiaowei.ren@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Xudong Hao <xudong.hao@intel.com>,
Liu Jinsong <jinsong.liu@intel.com>
Subject: Re: [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition
Date: Fri, 06 Dec 2013 09:55:12 -0800 [thread overview]
Message-ID: <52A20F80.9000601@zytor.com> (raw)
In-Reply-To: <52A20AD6.8080706@redhat.com>
On 12/06/2013 09:35 AM, Paolo Bonzini wrote:
>
> Sorry for the back-and-forth, but I think this and the removal of
> XSTATE_FLEXIBLE (perhaps XSTATE_LAZY?) makes your v2 worse than v1.
>
> Since Peter already said the same, please undo these changes.
>
> Also, how is XSTATE_EAGER used? Should MPX be disabled when xsaveopt is
> disabled on the kernel command line? (Liu, how would this affect the
> KVM patches, too?)
>
There are two options: we could disable MPX etc. or we could force eager
saving (using xsave) even if xsaveopt is disabled. It is a hard call to
make, but I guess I'm leaning towards the latter; we could add an
"lazyxsave" option to explicitly disable all eager features if there is
use for that.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Qiaowei Ren <qiaowei.ren@intel.com>
Cc: Liu Jinsong <jinsong.liu@intel.com>,
kvm@vger.kernel.org, x86@kernel.org,
Xudong Hao <xudong.hao@intel.com>,
qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition
Date: Fri, 06 Dec 2013 09:55:12 -0800 [thread overview]
Message-ID: <52A20F80.9000601@zytor.com> (raw)
In-Reply-To: <52A20AD6.8080706@redhat.com>
On 12/06/2013 09:35 AM, Paolo Bonzini wrote:
>
> Sorry for the back-and-forth, but I think this and the removal of
> XSTATE_FLEXIBLE (perhaps XSTATE_LAZY?) makes your v2 worse than v1.
>
> Since Peter already said the same, please undo these changes.
>
> Also, how is XSTATE_EAGER used? Should MPX be disabled when xsaveopt is
> disabled on the kernel command line? (Liu, how would this affect the
> KVM patches, too?)
>
There are two options: we could disable MPX etc. or we could force eager
saving (using xsave) even if xsaveopt is disabled. It is a hard call to
make, but I guess I'm leaning towards the latter; we could add an
"lazyxsave" option to explicitly disable all eager features if there is
use for that.
-hpa
next prev parent reply other threads:[~2013-12-06 17:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 0:20 [PATCH v2 1/3] x86, mpx: add documentation on Intel MPX Qiaowei Ren
2013-12-07 0:20 ` [Qemu-devel] " Qiaowei Ren
2013-12-07 0:20 ` [PATCH v2 2/3] X86, mpx: Intel MPX CPU feature definition Qiaowei Ren
2013-12-07 0:20 ` [Qemu-devel] " Qiaowei Ren
2013-12-06 18:25 ` [tip:x86/cpufeature] x86, cpufeature: Define the Intel MPX feature flag tip-bot for Qiaowei Ren
2013-12-07 0:20 ` [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition Qiaowei Ren
2013-12-07 0:20 ` [Qemu-devel] " Qiaowei Ren
2013-12-06 17:35 ` Paolo Bonzini
2013-12-06 17:35 ` [Qemu-devel] " Paolo Bonzini
2013-12-06 17:55 ` H. Peter Anvin [this message]
2013-12-06 17:55 ` H. Peter Anvin
2013-12-06 20:05 ` Liu, Jinsong
2013-12-06 20:05 ` [Qemu-devel] " Liu, Jinsong
2013-12-06 20:05 ` Liu, Jinsong
2013-12-06 21:33 ` H. Peter Anvin
2013-12-06 21:33 ` H. Peter Anvin
2013-12-06 22:12 ` Liu, Jinsong
2013-12-06 22:12 ` [Qemu-devel] " Liu, Jinsong
2013-12-06 22:12 ` Liu, Jinsong
2013-12-07 0:23 ` Ren, Qiaowei
2013-12-07 0:23 ` [Qemu-devel] " Ren, Qiaowei
2013-12-07 0:23 ` Ren, Qiaowei
2013-12-07 1:07 ` H. Peter Anvin
2013-12-07 1:07 ` [Qemu-devel] " H. Peter Anvin
2013-12-07 1:07 ` H. Peter Anvin
2013-12-07 1:16 ` Ren, Qiaowei
2013-12-07 1:16 ` Ren, Qiaowei
2013-12-07 1:16 ` Ren, Qiaowei
2013-12-07 1:19 ` H. Peter Anvin
2013-12-07 1:19 ` H. Peter Anvin
2013-12-07 1:21 ` [tip:x86/cpufeature] x86, xsave: Support eager-only xsave features, add MPX support tip-bot for Qiaowei Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A20F80.9000601@zytor.com \
--to=hpa@zytor.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.