All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] eeprom93xx: fix coding style
Date: Fri, 06 Dec 2013 22:59:29 +0400	[thread overview]
Message-ID: <52A21E91.7070404@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386138449-1235-1-git-send-email-antonynpavlov@gmail.com>

04.12.2013 10:27, Antony Pavlov wrote:
> scripts/checkpatch.pl reports about some style problems,
> this commit fixes some of them:

Thanks, applied to trivial-patches queue.

I'm a bit afraid of this sort of patches - there are LOTS of
coding style issues in current qemu code base, and applying
a patch like this may open a really large can of worms...

Generally it has been agreed to fix coding style only when
doing some other code changes nearby, as far as I remember.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] eeprom93xx: fix coding style
Date: Fri, 06 Dec 2013 22:59:29 +0400	[thread overview]
Message-ID: <52A21E91.7070404@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386138449-1235-1-git-send-email-antonynpavlov@gmail.com>

04.12.2013 10:27, Antony Pavlov wrote:
> scripts/checkpatch.pl reports about some style problems,
> this commit fixes some of them:

Thanks, applied to trivial-patches queue.

I'm a bit afraid of this sort of patches - there are LOTS of
coding style issues in current qemu code base, and applying
a patch like this may open a really large can of worms...

Generally it has been agreed to fix coding style only when
doing some other code changes nearby, as far as I remember.

/mjt

  parent reply	other threads:[~2013-12-06 18:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04  6:27 [Qemu-trivial] [PATCH] eeprom93xx: fix coding style Antony Pavlov
2013-12-04  6:27 ` [Qemu-devel] " Antony Pavlov
2013-12-04  6:29 ` [Qemu-trivial] " Stefan Weil
2013-12-04  6:29   ` [Qemu-devel] " Stefan Weil
2013-12-06 18:59 ` Michael Tokarev [this message]
2013-12-06 18:59   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-12-07  1:14   ` Antony Pavlov
2013-12-07  1:14     ` [Qemu-devel] " Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A21E91.7070404@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=antonynpavlov@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.