All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] help: add id suboption to -iscsi
Date: Fri, 06 Dec 2013 23:04:53 +0400	[thread overview]
Message-ID: <52A21FD5.6080101@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386342485-8656-1-git-send-email-pbonzini@redhat.com>

06.12.2013 19:08, Paolo Bonzini wrote:
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2089,7 +2089,7 @@ ETEXI
>  DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
>      "-iscsi [user=user][,password=password]\n"
>      "       [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> -    "       [,initiator-name=iqn]\n"
> +    "       [,initiator-name=initiator-iqn][,id=target-iqn]\n"
>      "                iSCSI session parameters\n", QEMU_ARCH_ALL)
>  STEXI

I'm not sure this is clearer, to me it looks more confusing
than before.

The thing is that "id" suboption is automatic and is handled
in the option parsing code explicitly.

As far as I can see, "id" suboption is actually never used by
iscsi code, only initiator-name is.

What this change is for?

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] help: add id suboption to -iscsi
Date: Fri, 06 Dec 2013 23:04:53 +0400	[thread overview]
Message-ID: <52A21FD5.6080101@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386342485-8656-1-git-send-email-pbonzini@redhat.com>

06.12.2013 19:08, Paolo Bonzini wrote:
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2089,7 +2089,7 @@ ETEXI
>  DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
>      "-iscsi [user=user][,password=password]\n"
>      "       [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> -    "       [,initiator-name=iqn]\n"
> +    "       [,initiator-name=initiator-iqn][,id=target-iqn]\n"
>      "                iSCSI session parameters\n", QEMU_ARCH_ALL)
>  STEXI

I'm not sure this is clearer, to me it looks more confusing
than before.

The thing is that "id" suboption is automatic and is handled
in the option parsing code explicitly.

As far as I can see, "id" suboption is actually never used by
iscsi code, only initiator-name is.

What this change is for?

Thanks,

/mjt

  reply	other threads:[~2013-12-06 19:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 15:08 [Qemu-trivial] [PATCH] help: add id suboption to -iscsi Paolo Bonzini
2013-12-06 15:08 ` [Qemu-devel] " Paolo Bonzini
2013-12-06 19:04 ` Michael Tokarev [this message]
2013-12-06 19:04   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-12-06 20:44   ` Paolo Bonzini
2013-12-06 20:44     ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A21FD5.6080101@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.