From: Gary Thomas <gary@mlbassoc.com>
To: Eric Nelson <eric.nelson@boundarydevices.com>,
meta-freescale@yoctoproject.org
Subject: Re: [PATCH] More changes for git fetchers
Date: Sat, 07 Dec 2013 05:00:09 -0700 [thread overview]
Message-ID: <52A30DC9.9080401@mlbassoc.com> (raw)
In-Reply-To: <52A269E4.4040306@boundarydevices.com>
On 2013-12-06 17:20, Eric Nelson wrote:
> Hi Gary,
>
> On 12/06/2013 11:51 AM, Gary Thomas wrote:
>> Recipes now need to explicitly mention the branch used for git repositories.
>> These changes reflect this, allowing for the branch to be overridden by
>> .bbappend files
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>
>> ---
>> recipes-bsp/u-boot/u-boot-boundary_git.bb | 3 ++-
>> recipes-bsp/u-boot/u-boot-script-boundary_git.bb | 3 ++-
>> recipes-kernel/linux/linux-boundary_3.0.35.bb | 4 ++--
>> 3 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/recipes-bsp/u-boot/u-boot-boundary_git.bb b/recipes-bsp/u-boot/u-boot-boundary_git.bb
>> index f612b3f..323cfdf 100644
>> --- a/recipes-bsp/u-boot/u-boot-boundary_git.bb
>> +++ b/recipes-bsp/u-boot/u-boot-boundary_git.bb
>> @@ -9,7 +9,8 @@ PROVIDES = "u-boot"
>> PV = "v2013.07+git${SRCPV}"
>>
>> SRCREV = "f89bc066db0569008418fac1a0408a9a57f2232f"
>> -SRC_URI = "git://github.com/boundarydevices/u-boot-imx6.git"
>> +SRCBRANCH = "production-before-20131107"
>> +SRC_URI = "git://github.com/boundarydevices/u-boot-imx6.git;branch=${SRCBRANCH}"
>>
>> S = "${WORKDIR}/git"
>>
>
> I'm not quite grokking why both the branch and the SRCREV are needed.
>
> It seems that SRCREV is more specific than the branch.
Except that the bitbake fetch code recently changed and if the SRCREV is not
on the master branch, it will fail like this:
ERROR: Fetcher failure: Unable to find revision f89bc066db0569008418fac1a0408a9a57f2232f in branch master even from upstream
ERROR: Function failed: Fetcher failure for URL: 'git://github.com/boundarydevices/u-boot-imx6.git'. Unable to fetch URL from any source.
ERROR: Logfile of failure stored in: /local/imx6_new/tmp/work/sabrelite-amltd-linux-gnueabi/u-boot-script-boundary/v2013.01+gitAUTOINC+f89bc066db-r0/temp/log.do_fetch.25222
ERROR: Task 144 (/local/poky-multi/meta-fsl-arm-extra/recipes-bsp/u-boot/u-boot-script-boundary_git.bb, do_fetch) failed with exit code '1'
I made the branch name a variable as not everyone using a given recipe
may be using the same revision/branch, e.g. I have some targets that use
linux-boundary that are still on boundary-imx_3.0.35_4.0.0
>
>> diff --git a/recipes-bsp/u-boot/u-boot-script-boundary_git.bb b/recipes-bsp/u-boot/u-boot-script-boundary_git.bb
>> index 06ad438..d14e094 100644
>> --- a/recipes-bsp/u-boot/u-boot-script-boundary_git.bb
>> +++ b/recipes-bsp/u-boot/u-boot-script-boundary_git.bb
>> @@ -6,7 +6,8 @@ DEPENDS = "u-boot-mkimage-native"
>> PV = "v2013.01+git${SRCPV}"
>>
>> SRCREV = "f89bc066db0569008418fac1a0408a9a57f2232f"
>> -SRC_URI = "git://github.com/boundarydevices/u-boot-imx6.git"
>> +SRCBRANCH = "production-before-20131107"
>> +SRC_URI = "git://github.com/boundarydevices/u-boot-imx6.git;branch=${SRCBRANCH}"
>>
>> S = "${WORKDIR}/git"
>>
>> diff --git a/recipes-kernel/linux/linux-boundary_3.0.35.bb b/recipes-kernel/linux/linux-boundary_3.0.35.bb
>> index 7875f93..872cab2 100644
>> --- a/recipes-kernel/linux/linux-boundary_3.0.35.bb
>> +++ b/recipes-kernel/linux/linux-boundary_3.0.35.bb
>> @@ -5,12 +5,12 @@ require recipes-kernel/linux/linux-imx.inc
>>
>> DESCRIPTION = "Linux kernel for Boundary Devices boards"
>>
>> -SRC_URI = "git://github.com/boundarydevices/linux-imx6.git \
>> +SRC_URI = "git://github.com/boundarydevices/linux-imx6.git;branch=${SRCBRANCH} \
>> file://defconfig"
>>
>> LOCALVERSION = "-4.1.0+yocto"
>> SRCREV = "58099389255add7c17ce6babf37a50ce5d11d6b8"
>> -
>> +SRCBRANCH = "boundary-imx_3.0.35_4.1.0"
>>
>> # GPU support patches
>> SRC_URI += "file://drm-vivante-Add-00-sufix-in-returned-bus-Id.patch \
>>
>
> BTW, I need to update both of these (U-Boot and 3.0.35 kernel), as we
> have some patches I think most folks will want.
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2013-12-07 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 18:51 [PATCH] More changes for git fetchers Gary Thomas
2013-12-07 0:20 ` Eric Nelson
2013-12-07 12:00 ` Gary Thomas [this message]
2013-12-07 16:53 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A30DC9.9080401@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=eric.nelson@boundarydevices.com \
--cc=meta-freescale@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.