Re: [PATCH] More changes for git fetchers

[Eric Nelson <eric.nelson@boundarydevices.com>]

On 12/07/2013 05:00 AM, Gary Thomas wrote:
> On 2013-12-06 17:20, Eric Nelson wrote:
>> Hi Gary,
>>
>> On 12/06/2013 11:51 AM, Gary Thomas wrote:
>>> Recipes now need to explicitly mention the branch used for git
>>> repositories.
>>> These changes reflect this, allowing for the branch to be overridden by
>>> .bbappend files
>>>
>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>>
>>> ---
>>>   recipes-bsp/u-boot/u-boot-boundary_git.bb        |    3 ++-
>>>   recipes-bsp/u-boot/u-boot-script-boundary_git.bb |    3 ++-
>>>   recipes-kernel/linux/linux-boundary_3.0.35.bb    |    4 ++--
>>>   3 files changed, 6 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/recipes-bsp/u-boot/u-boot-boundary_git.bb
>>> b/recipes-bsp/u-boot/u-boot-boundary_git.bb
>>> index f612b3f..323cfdf 100644
>>> --- a/recipes-bsp/u-boot/u-boot-boundary_git.bb
>>> +++ b/recipes-bsp/u-boot/u-boot-boundary_git.bb
>>> @@ -9,7 +9,8 @@ PROVIDES = "u-boot"
>>>   PV = "v2013.07+git${SRCPV}"
>>>
>>>   SRCREV = "f89bc066db0569008418fac1a0408a9a57f2232f"
>>> -SRC_URI = "git://github.com/boundarydevices/u-boot-imx6.git"
>>> +SRCBRANCH = "production-before-20131107"
>>> +SRC_URI =
>>> "git://github.com/boundarydevices/u-boot-imx6.git;branch=${SRCBRANCH}"
>>>
>>>   S = "${WORKDIR}/git"
>>>
>>
>> I'm not quite grokking why both the branch and the SRCREV are needed.
>>
>> It seems that SRCREV is more specific than the branch.
>
> Except that the bitbake fetch code recently changed and if the SRCREV is
> not
> on the master branch, it will fail like this:
>    ERROR: Fetcher failure: Unable to find revision
>

Thanks. I hadn't noticed.

 >  <snip>
>
> I made the branch name a variable as not everyone using a given recipe
> may be using the same revision/branch, e.g. I have some targets that use
> linux-boundary that are still on boundary-imx_3.0.35_4.0.0
>

That makes sense.