All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Amos Kong <akong@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	pbonzini@redhat.com, qemu-devel@nongnu.org,
	anthony@codemonkey.ws, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 0/2] fix strict boot regression
Date: Mon, 09 Dec 2013 12:16:00 +0400	[thread overview]
Message-ID: <52A57C40.2000502@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386576358-10469-1-git-send-email-akong@redhat.com>

09.12.2013 12:05, Amos Kong wrote:
> parsing of "strict" is wrongly removed, we need it.
> The first patch fixes a typo.
> 
> V2: remove bios.bin change, I just used it for testing (mjt)
> 
> Amos Kong (2):
>   fix a typo of strict option
>   add parsing of "strict" boot parameter
> 
>  vl.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

I think it is okay to go to qemu-trivial (both patches are fine to my eyes).
I queued them up for now, will roll back if there's any objections.  At any
rate,

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Note that boot_strict can be made static since it isn't used anywhere else.
I'll queue this change too.

Thanks,

/mjt



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Amos Kong <akong@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	pbonzini@redhat.com, qemu-devel@nongnu.org,
	anthony@codemonkey.ws, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] fix strict boot regression
Date: Mon, 09 Dec 2013 12:16:00 +0400	[thread overview]
Message-ID: <52A57C40.2000502@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386576358-10469-1-git-send-email-akong@redhat.com>

09.12.2013 12:05, Amos Kong wrote:
> parsing of "strict" is wrongly removed, we need it.
> The first patch fixes a typo.
> 
> V2: remove bios.bin change, I just used it for testing (mjt)
> 
> Amos Kong (2):
>   fix a typo of strict option
>   add parsing of "strict" boot parameter
> 
>  vl.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

I think it is okay to go to qemu-trivial (both patches are fine to my eyes).
I queued them up for now, will roll back if there's any objections.  At any
rate,

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Note that boot_strict can be made static since it isn't used anywhere else.
I'll queue this change too.

Thanks,

/mjt

  parent reply	other threads:[~2013-12-09  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  8:05 [Qemu-devel] [PATCH v2 0/2] fix strict boot regression Amos Kong
2013-12-09  8:05 ` [Qemu-devel] [PATCH v2 1/2] fix a typo of strict option Amos Kong
2013-12-09  9:16   ` Markus Armbruster
2013-12-09 11:55     ` Amos Kong
2013-12-09  8:05 ` [Qemu-devel] [PATCH v2 2/2] add parsing of "strict" boot parameter Amos Kong
2013-12-09  9:25   ` Markus Armbruster
2013-12-09  8:16 ` Michael Tokarev [this message]
2013-12-09  8:16   ` [Qemu-devel] [PATCH v2 0/2] fix strict boot regression Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A57C40.2000502@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=akong@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.