From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
Date: Mon, 09 Dec 2013 09:31:28 +0100 [thread overview]
Message-ID: <52A57FE0.5030009@pengutronix.de> (raw)
In-Reply-To: <1386570664-6713-9-git-send-email-peter.chen@freescale.com>
On 12/09/2013 07:30 AM, Peter Chen wrote:
> Implementation of notify_suspend and notify_resume will be different
> according to mxs_phy_data->flags.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
> drivers/usb/phy/phy-mxs-usb.c | 55 ++++++++++++++++++++++++++++++++++++++---
> 1 files changed, 51 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index 0ef930a..e3df53f 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -166,8 +166,8 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)
> static int mxs_phy_on_connect(struct usb_phy *phy,
> enum usb_device_speed speed)
> {
> - dev_dbg(phy->dev, "%s speed device has connected\n",
> - (speed == USB_SPEED_HIGH) ? "high" : "non-high");
> + dev_dbg(phy->dev, "%s device has connected\n",
> + (speed == USB_SPEED_HIGH) ? "HS" : "FS/LS");
What about creating a mxs_phy_dbg() function that adds the "HS" "FS/LS"
prefix when printing?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/13500789/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Peter Chen <peter.chen@freescale.com>
Cc: balbi@ti.com, shawn.guo@linaro.org, rob.herring@calxeda.com,
grant.likely@linaro.org, alexander.shishkin@linux.intel.com,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
festevam@gmail.com, marex@denx.de, kernel@pengutronix.de,
m.grzeschik@pengutronix.de, frank.li@freescale.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
Date: Mon, 09 Dec 2013 09:31:28 +0100 [thread overview]
Message-ID: <52A57FE0.5030009@pengutronix.de> (raw)
In-Reply-To: <1386570664-6713-9-git-send-email-peter.chen@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
On 12/09/2013 07:30 AM, Peter Chen wrote:
> Implementation of notify_suspend and notify_resume will be different
> according to mxs_phy_data->flags.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
> drivers/usb/phy/phy-mxs-usb.c | 55 ++++++++++++++++++++++++++++++++++++++---
> 1 files changed, 51 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index 0ef930a..e3df53f 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -166,8 +166,8 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)
> static int mxs_phy_on_connect(struct usb_phy *phy,
> enum usb_device_speed speed)
> {
> - dev_dbg(phy->dev, "%s speed device has connected\n",
> - (speed == USB_SPEED_HIGH) ? "high" : "non-high");
> + dev_dbg(phy->dev, "%s device has connected\n",
> + (speed == USB_SPEED_HIGH) ? "HS" : "FS/LS");
What about creating a mxs_phy_dbg() function that adds the "HS" "FS/LS"
prefix when printing?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-12-09 8:31 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 6:30 [PATCH v5 00/15] Add power management support for mxs phy Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 05/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 06/15] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 07/15] usb: phy: add notify suspend and resume callback Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 8:31 ` Marc Kleine-Budde [this message]
2013-12-09 8:31 ` Marc Kleine-Budde
2013-12-09 9:00 ` Peter Chen
2013-12-09 9:00 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 09/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 8:38 ` Marc Kleine-Budde
2013-12-09 8:38 ` Marc Kleine-Budde
2013-12-09 9:07 ` Peter Chen
2013-12-09 9:07 ` Peter Chen
2013-12-09 9:52 ` Marc Kleine-Budde
2013-12-09 9:52 ` Marc Kleine-Budde
2013-12-10 1:45 ` Peter Chen
2013-12-10 1:45 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 10/15] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-09 6:30 ` Peter Chen
2013-12-09 6:31 ` [PATCH v5 11/15] usb: phy-mxs: add " Peter Chen
2013-12-09 6:31 ` Peter Chen
2013-12-09 6:31 ` [PATCH v5 12/15] usb: phy: Add set_wakeup API Peter Chen
2013-12-09 6:31 ` Peter Chen
2013-12-09 8:41 ` Marc Kleine-Budde
2013-12-09 8:41 ` Marc Kleine-Budde
2013-12-09 9:12 ` Peter Chen
2013-12-09 9:12 ` Peter Chen
2013-12-09 6:31 ` [PATCH v5 13/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-09 6:31 ` Peter Chen
2013-12-09 6:31 ` [PATCH v5 14/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-09 6:31 ` Peter Chen
2013-12-09 6:31 ` [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-09 6:31 ` Peter Chen
2013-12-09 9:05 ` Marc Kleine-Budde
2013-12-09 9:05 ` Marc Kleine-Budde
2013-12-09 9:19 ` Peter Chen
2013-12-09 9:19 ` Peter Chen
2013-12-09 10:00 ` Marc Kleine-Budde
2013-12-09 10:00 ` Marc Kleine-Budde
2013-12-09 18:20 ` Sergei Shtylyov
2013-12-09 18:20 ` Sergei Shtylyov
2013-12-10 1:47 ` Peter Chen
2013-12-10 1:47 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A57FE0.5030009@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.