From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alex Thorlton <athorlton@sgi.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/18] mm: numa: Do not clear PTE for pte_numa update
Date: Mon, 09 Dec 2013 09:31:00 -0500 [thread overview]
Message-ID: <52A5D424.7030901@redhat.com> (raw)
In-Reply-To: <1386572952-1191-6-git-send-email-mgorman@suse.de>
On 12/09/2013 02:08 AM, Mel Gorman wrote:
> The TLB must be flushed if the PTE is updated but change_pte_range is clearing
> the PTE while marking PTEs pte_numa without necessarily flushing the TLB if it
> reinserts the same entry. Without the flush, it's conceivable that two processors
> have different TLBs for the same virtual address and at the very least it would
> generate spurious faults. This patch only unmaps the pages in change_pte_range for
> a full protection change.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alex Thorlton <athorlton@sgi.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/18] mm: numa: Do not clear PTE for pte_numa update
Date: Mon, 09 Dec 2013 09:31:00 -0500 [thread overview]
Message-ID: <52A5D424.7030901@redhat.com> (raw)
In-Reply-To: <1386572952-1191-6-git-send-email-mgorman@suse.de>
On 12/09/2013 02:08 AM, Mel Gorman wrote:
> The TLB must be flushed if the PTE is updated but change_pte_range is clearing
> the PTE while marking PTEs pte_numa without necessarily flushing the TLB if it
> reinserts the same entry. Without the flush, it's conceivable that two processors
> have different TLBs for the same virtual address and at the very least it would
> generate spurious faults. This patch only unmaps the pages in change_pte_range for
> a full protection change.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
next prev parent reply other threads:[~2013-12-09 14:31 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 7:08 [PATCH 00/18] NUMA balancing segmentation fault fixes and misc followups v3 Mel Gorman
2013-12-09 7:08 ` Mel Gorman
2013-12-09 7:08 ` [PATCH 01/18] mm: numa: Serialise parallel get_user_page against THP migration Mel Gorman
2013-12-09 7:08 ` Mel Gorman
2013-12-09 14:08 ` Rik van Riel
2013-12-09 14:08 ` Rik van Riel
2013-12-09 7:08 ` [PATCH 02/18] mm: numa: Call MMU notifiers on " Mel Gorman
2013-12-09 7:08 ` Mel Gorman
2013-12-09 14:09 ` Rik van Riel
2013-12-09 14:09 ` Rik van Riel
2013-12-09 7:08 ` [PATCH 03/18] mm: Clear pmd_numa before invalidating Mel Gorman
2013-12-09 7:08 ` Mel Gorman
2013-12-09 14:14 ` Rik van Riel
2013-12-09 14:14 ` Rik van Riel
2013-12-09 7:08 ` [PATCH 04/18] mm: numa: Do not clear PMD during PTE update scan Mel Gorman
2013-12-09 7:08 ` Mel Gorman
2013-12-09 14:22 ` Rik van Riel
2013-12-09 14:22 ` Rik van Riel
2013-12-09 7:08 ` [PATCH 05/18] mm: numa: Do not clear PTE for pte_numa update Mel Gorman
2013-12-09 7:08 ` Mel Gorman
2013-12-09 14:31 ` Rik van Riel [this message]
2013-12-09 14:31 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 06/18] mm: numa: Ensure anon_vma is locked to prevent parallel THP splits Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 14:34 ` Rik van Riel
2013-12-09 14:34 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 07/18] mm: numa: Avoid unnecessary work on the failure path Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 14:42 ` Rik van Riel
2013-12-09 14:42 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 08/18] sched: numa: Skip inaccessible VMAs Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 14:50 ` Rik van Riel
2013-12-09 14:50 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 09/18] mm: numa: Clear numa hinting information on mprotect Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 15:57 ` Rik van Riel
2013-12-09 15:57 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 10/18] mm: numa: Avoid unnecessary disruption of NUMA hinting during migration Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 16:10 ` Rik van Riel
2013-12-09 16:10 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 11/18] mm: fix TLB flush race between migration, and change_protection_range Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-10 14:25 ` Rik van Riel
2013-12-10 14:25 ` Rik van Riel
2013-12-10 17:19 ` Mel Gorman
2013-12-10 17:19 ` Mel Gorman
2013-12-10 18:02 ` Paul E. McKenney
2013-12-10 18:02 ` Paul E. McKenney
2013-12-11 11:21 ` Mel Gorman
2013-12-11 11:21 ` Mel Gorman
2013-12-09 7:09 ` [PATCH 12/18] mm: numa: Defer TLB flush for THP migration as long as possible Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 16:13 ` Rik van Riel
2013-12-09 16:13 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 13/18] mm: numa: Make NUMA-migrate related functions static Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 7:20 ` Wanpeng Li
[not found] ` <20131209072010.GA3716@hacker.(null)>
2013-12-09 8:46 ` Mel Gorman
2013-12-09 8:46 ` Mel Gorman
2013-12-09 8:57 ` Wanpeng Li
[not found] ` <20131209085720.GA16251@hacker.(null)>
2013-12-09 9:08 ` Mel Gorman
2013-12-09 9:08 ` Mel Gorman
2013-12-09 9:13 ` Wanpeng Li
2013-12-09 16:14 ` Rik van Riel
2013-12-09 16:14 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 14/18] mm: numa: Limit scope of lock for NUMA migrate rate limiting Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 16:47 ` Rik van Riel
2013-12-09 16:47 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 15/18] mm: numa: Trace tasks that fail migration due to " Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 16:57 ` Rik van Riel
2013-12-09 16:57 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 16/18] mm: numa: Do not automatically migrate KSM pages Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 16:57 ` Rik van Riel
2013-12-09 16:57 ` Rik van Riel
2013-12-09 7:09 ` [PATCH 17/18] sched: Tracepoint task movement Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 18:54 ` Rik van Riel
2013-12-09 18:54 ` Rik van Riel
2013-12-10 8:42 ` Mel Gorman
2013-12-10 8:42 ` Mel Gorman
2013-12-10 9:06 ` Andrew Jones
2013-12-10 9:06 ` Andrew Jones
2013-12-09 7:09 ` [PATCH 18/18] sched: Add tracepoints related to NUMA task migration Mel Gorman
2013-12-09 7:09 ` Mel Gorman
2013-12-09 19:06 ` Rik van Riel
2013-12-09 19:06 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2013-12-10 15:51 [PATCH 00/17] NUMA balancing segmentation fault fixes and misc followups v4 Mel Gorman
2013-12-10 15:51 ` [PATCH 05/18] mm: numa: Do not clear PTE for pte_numa update Mel Gorman
2013-12-10 15:51 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A5D424.7030901@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.