[PATCH V2] usb: phy: R-Car Gen2: Use usb_add_phy_dev

[PATCH V2] usb: phy: R-Car Gen2: Use usb_add_phy_dev

[Valentine Barshak]

Use usb_add_phy_dev instead of usb_add_phy, so that devices can
be bound to the phy. This is needed to set up USB phy for
some internal PCI USB host controllers on R-Car Gen2.

Changes from previous version:
* Fixed function names in the commit log

Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
---
 drivers/usb/phy/phy-rcar-gen2-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
index db3ab34..551e0a6 100644
--- a/drivers/usb/phy/phy-rcar-gen2-usb.c
+++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
@@ -213,7 +213,7 @@ static int rcar_gen2_usb_phy_probe(struct platform_device *pdev)
 	priv->phy.shutdown = rcar_gen2_usb_phy_shutdown;
 	priv->phy.set_suspend = rcar_gen2_usb_phy_set_suspend;
 
-	retval = usb_add_phy(&priv->phy, USB_PHY_TYPE_USB2);
+	retval = usb_add_phy_dev(&priv->phy);
 	if (retval < 0) {
 		dev_err(dev, "Failed to add USB phy\n");
 		return retval;
-- 
1.8.3.1

Re: [PATCH V2] usb: phy: R-Car Gen2: Use usb_add_phy_dev

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi,

On Mon, Dec 09, 2013 at 11:40:33PM +0400, Valentine Barshak wrote:
> Use usb_add_phy_dev instead of usb_add_phy, so that devices can
> be bound to the phy. This is needed to set up USB phy for
> some internal PCI USB host controllers on R-Car Gen2.
> 
> Changes from previous version:
> * Fixed function names in the commit log
> 
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>

Was this a regression on v3.13 or can it wait for v3.14 ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH V2] usb: phy: R-Car Gen2: Use usb_add_phy_dev

[Valentine]

On 12/09/2013 11:41 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Dec 09, 2013 at 11:40:33PM +0400, Valentine Barshak wrote:
>> Use usb_add_phy_dev instead of usb_add_phy, so that devices can
>> be bound to the phy. This is needed to set up USB phy for
>> some internal PCI USB host controllers on R-Car Gen2.
>>
>> Changes from previous version:
>> * Fixed function names in the commit log
>>
>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>
> Was this a regression on v3.13 or can it wait for v3.14 ?
>

I hope it's OK to have it on 3.13.

The major reason for the change is to use the USB HCD phy handling
updates that are available now in the usb-next branch of Greg's tree:
commit 1ae5799ef6: usb: hcd: Initialize USB phy if needed

Thanks,
Val.

Re: [PATCH V2] usb: phy: R-Car Gen2: Use usb_add_phy_dev

[Greg Kroah-Hartman]

On Tue, Dec 10, 2013 at 12:16:13AM +0400, Valentine wrote:
> On 12/09/2013 11:41 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Dec 09, 2013 at 11:40:33PM +0400, Valentine Barshak wrote:
> >> Use usb_add_phy_dev instead of usb_add_phy, so that devices can
> >> be bound to the phy. This is needed to set up USB phy for
> >> some internal PCI USB host controllers on R-Car Gen2.
> >>
> >> Changes from previous version:
> >> * Fixed function names in the commit log
> >>
> >> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
> >
> > Was this a regression on v3.13 or can it wait for v3.14 ?
> >
> 
> I hope it's OK to have it on 3.13.
> 
> The major reason for the change is to use the USB HCD phy handling
> updates that are available now in the usb-next branch of Greg's tree:
> commit 1ae5799ef6: usb: hcd: Initialize USB phy if needed

But that patch isn't going to Linus until 3.14, so this has to wait
until then as well.

sorry,

greg k-h

Re: [PATCH V2] usb: phy: R-Car Gen2: Use usb_add_phy_dev

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On Mon, Dec 09, 2013 at 12:32:37PM -0800, Greg Kroah-Hartman wrote:
> On Tue, Dec 10, 2013 at 12:16:13AM +0400, Valentine wrote:
> > On 12/09/2013 11:41 PM, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Mon, Dec 09, 2013 at 11:40:33PM +0400, Valentine Barshak wrote:
> > >> Use usb_add_phy_dev instead of usb_add_phy, so that devices can
> > >> be bound to the phy. This is needed to set up USB phy for
> > >> some internal PCI USB host controllers on R-Car Gen2.
> > >>
> > >> Changes from previous version:
> > >> * Fixed function names in the commit log
> > >>
> > >> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
> > >
> > > Was this a regression on v3.13 or can it wait for v3.14 ?
> > >
> > 
> > I hope it's OK to have it on 3.13.
> > 
> > The major reason for the change is to use the USB HCD phy handling
> > updates that are available now in the usb-next branch of Greg's tree:
> > commit 1ae5799ef6: usb: hcd: Initialize USB phy if needed
> 
> But that patch isn't going to Linus until 3.14, so this has to wait
> until then as well.

3.14 it is, thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]