All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] multipathd: Fix for 'Read environment variables from systemd'
@ 2013-12-10  1:41 Ondřej Svoboda
  2013-12-10  1:49 ` Ondřej Svoboda
  0 siblings, 1 reply; 2+ messages in thread
From: Ondřej Svoboda @ 2013-12-10  1:41 UTC (permalink / raw)
  To: dm-devel

The revision 'multipathd: Read environment variables from systemd' introduced a compilation error in multipathd/main.c:

main.c: In function ‘child’:
main.c:1651:2: error: ‘envp’ undeclared (first use in this function)
   envp = getenv("LimitNOFILE");
   ^

This patch fixes it by declaring char *envp for this (second) case.

Signed-off-by: Ondřej Svoboda <ondrej svobodasoft cz>

diff --git a/multipathd/main.c b/multipathd/main.c
index 7c0e313..2d6aac8 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1609,6 +1609,7 @@ child (void * param)
      struct multipath * mpp;
      int i;
      int rc, pid_rc;
+    char *envp;
  

      mlockall(MCL_CURRENT | MCL_FUTURE);
      sem_init(&exit_sem, 0, 0);

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] multipathd: Fix for 'Read environment variables from systemd'
  2013-12-10  1:41 [PATCH] multipathd: Fix for 'Read environment variables from systemd' Ondřej Svoboda
@ 2013-12-10  1:49 ` Ondřej Svoboda
  0 siblings, 0 replies; 2+ messages in thread
From: Ondřej Svoboda @ 2013-12-10  1:49 UTC (permalink / raw)
  To: dm-devel

Never mind, it’s too late for me.

On 10.12.2013 02:41, Ondřej Svoboda wrote:
> The revision 'multipathd: Read environment variables from systemd' 
> introduced a compilation error in multipathd/main.c:
>
> main.c: In function ‘child’:
> main.c:1651:2: error: ‘envp’ undeclared (first use in this function)
>   envp = getenv("LimitNOFILE");
>   ^
>
> This patch fixes it by declaring char *envp for this (second) case.
>
> Signed-off-by: Ondřej Svoboda <ondrej svobodasoft cz>
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 7c0e313..2d6aac8 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -1609,6 +1609,7 @@ child (void * param)
>      struct multipath * mpp;
>      int i;
>      int rc, pid_rc;
> +    char *envp;
>
>
>      mlockall(MCL_CURRENT | MCL_FUTURE);
>      sem_init(&exit_sem, 0, 0);
>
> -- 
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-10  1:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-10  1:41 [PATCH] multipathd: Fix for 'Read environment variables from systemd' Ondřej Svoboda
2013-12-10  1:49 ` Ondřej Svoboda

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.