All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	"David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: sk == 0xffffffff fix - not for commit
Date: Tue, 10 Dec 2013 07:55:02 +0100	[thread overview]
Message-ID: <52A6BAC6.4090407@samsung.com> (raw)
In-Reply-To: <1386603119.30495.331.camel@edumazet-glaptop2.roam.corp.google.com>

W dniu 09.12.2013 16:31, Eric Dumazet pisze:
> On Mon, 2013-12-09 at 12:47 +0100, Andrzej Pietrasiewicz wrote:
>> NOT FOR COMMITTING TO MAINLINE.
>>
>> With g_ether loaded the sk occasionally becomes 0xffffffff.
>> It happens usually after transferring few hundreds of kilobytes to few
>> tens of megabytes. If sk is 0xffffffff then dereferencing it causes
>> kernel panic.
>>
>> This is a *workaround*. I don't know enough net code to understand the core
>> of the problem. However, with this patch applied the problems are gone,
>> or at least pushed farther away.
>
> Is it happening on SMP or UP ?

UP build, S5PC110

>
> Crash should happen earlier in __inet_lookup_established()
>
>
>

AP

WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Pietrasiewicz <andrzej.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Michal Nazarewicz
	<mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>,
	James Morris <jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>,
	Hideaki YOSHIFUJI
	<yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org>,
	Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] net: sk == 0xffffffff fix - not for commit
Date: Tue, 10 Dec 2013 07:55:02 +0100	[thread overview]
Message-ID: <52A6BAC6.4090407@samsung.com> (raw)
In-Reply-To: <1386603119.30495.331.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>

W dniu 09.12.2013 16:31, Eric Dumazet pisze:
> On Mon, 2013-12-09 at 12:47 +0100, Andrzej Pietrasiewicz wrote:
>> NOT FOR COMMITTING TO MAINLINE.
>>
>> With g_ether loaded the sk occasionally becomes 0xffffffff.
>> It happens usually after transferring few hundreds of kilobytes to few
>> tens of megabytes. If sk is 0xffffffff then dereferencing it causes
>> kernel panic.
>>
>> This is a *workaround*. I don't know enough net code to understand the core
>> of the problem. However, with this patch applied the problems are gone,
>> or at least pushed farther away.
>
> Is it happening on SMP or UP ?

UP build, S5PC110

>
> Crash should happen earlier in __inet_lookup_established()
>
>
>

AP
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-12-10  6:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 11:47 [PATCH] net: sk == 0xffffffff fix - not for commit Andrzej Pietrasiewicz
2013-12-09 11:47 ` Andrzej Pietrasiewicz
2013-12-09 15:31 ` Eric Dumazet
2013-12-10  6:55   ` Andrzej Pietrasiewicz [this message]
2013-12-10  6:55     ` Andrzej Pietrasiewicz
2013-12-10 14:25     ` Eric Dumazet
2013-12-10 14:25       ` Eric Dumazet
2014-01-16 15:21       ` Andrzej Pietrasiewicz
2014-01-16 16:29         ` Eric Dumazet
2014-01-17 12:18           ` Andrzej Pietrasiewicz
2014-01-17 12:47             ` Andrzej Pietrasiewicz
2014-01-17  0:01 ` Andrew Ruder
2014-01-17  0:01   ` Andrew Ruder
2014-01-24 13:38 ` Andrew Ruder
2014-01-24 14:15   ` Andrew Ruder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A6BAC6.4090407@samsung.com \
    --to=andrzej.p@samsung.com \
    --cc=balbi@ti.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mina86@mina86.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.