Re: [PATCH 16/26] ARM: omap4-sdp.dts: add display information

[Archit Taneja <archit@ti.com>]

On Wednesday 04 December 2013 05:58 PM, Tomi Valkeinen wrote:
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>   arch/arm/boot/dts/omap4-sdp.dts | 91 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 91 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 5fc3f43c5a81..e3048f849612 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -550,3 +550,94 @@
>   	mode = <3>;
>   	power = <50>;
>   };
> +
> +&dsi1 {
> +	vdds_dsi-supply = <&vcxio>;
> +
> +	dsi1_out_ep: endpoint {
> +		remote-endpoint = <&lcd0_in>;
> +		lanes = <0 1 2 3 4 5>;

In the previous revision omapdss DT patchset, the lanes node was a 
member of the panel DT node, and not the dsi DT node. Any reason to 
change this? Does it make more sense this way?

I suppose it's more suitable for dsi to hold the property if 2 panels 
are connected on the same bus. Say, one with 4 data lanes, and other 
with 2. It would be tricky for the dsi driver to get lane params from 2 
different places and merge them somehow.

> +	};
> +
> +	lcd0: display@0 {
> +		compatible = "tpo,taal", "panel-dsi-cm";
> +
> +		gpios = <&gpio4 6 0>;	/* 102, reset */
> +
> +		lcd0_in: endpoint {
> +			remote-endpoint = <&dsi1_out_ep>;
> +		};
> +	};

Is there a reason why lcd0 and lcd1 are children nodes of dsi1 and dsi2 
respectively? I don't see this for panels on other boards.

Archit