From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790 - fix shdi resource sies
Date: Fri, 13 Dec 2013 11:04:15 +0000 [thread overview]
Message-ID: <52AAE9AF.6010704@codethink.co.uk> (raw)
In-Reply-To: <CANqRtoT86xdh-c73f-_59sD3E=90yW1wOp5Bobmi4qJywA72uA@mail.gmail.com>
On 13/12/13 10:56, Magnus Damm wrote:
> Hey Morimoto-san,
>
> On Fri, Dec 13, 2013 at 11:37 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@gmail.com> wrote:
>>
>> Hi Ben
>>
>> Thank you for your patch
>>
>>> The r8a7790.dtsi file has three sdhi nodes which all have the wrong resource
>>> size for their register block. This causes the sh_modbile_sdhi driver to
>>> fail to communicate with card at-all.
>>>
>>> Change each sdhi node size from 0x100 to 0x200 to correct this.
>>>
>>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
>>> Cc: Magnus Damm <magnus.damm@gmail.com>
>>> Cc: Simon Horman <horms@verge.net.au>
>>> Cc: Linux SH <linux-sh@vger.kernel.org>
>>> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> Tested-by: William Towle <william.towle@codethink.co.uk>
>>> ---
>>
>> Unfortunately, sdhi resource size 0x100 is corrent on Renesas SDHI.
>> The wrong is SDHI/TMIO driver side, not SoC side.
>> Now, I'm working/sending sh_modbile_sdhi driver fixup patches for R-Car H2,
>> but it need more time (= there is merge timing issue)
>
> Thanks for supporting Ben regarding this SDHI issue.
>
> Would it be possible for you to share a list of patches needed to get
> SDHI working? If some parts are missing then please post them so the
> patches are available on public lists.
>
> I would like to make it possible for Ben to test your patch stack if
> he happens to have time.
Thanks, I think I have all the previous ones that where pushed to the
linux-sh list. If there's a git tree I could pull from that would make
our job easier.
We have got SDHI0 and SDHI2 working with device tree, but we're
currently seeing less than a megabyte a second when direcly dd-ing
blocks from the card. Is this a noted issue? We got ~11MiB without
DMA on the 3.4-ltsi series.
As a note, I will be away from the 20th December untill Janurary 6th
and it is likely the rest of the team here will be away from 21st.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7790 - fix shdi resource sies
Date: Fri, 13 Dec 2013 11:04:15 +0000 [thread overview]
Message-ID: <52AAE9AF.6010704@codethink.co.uk> (raw)
In-Reply-To: <CANqRtoT86xdh-c73f-_59sD3E=90yW1wOp5Bobmi4qJywA72uA@mail.gmail.com>
On 13/12/13 10:56, Magnus Damm wrote:
> Hey Morimoto-san,
>
> On Fri, Dec 13, 2013 at 11:37 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@gmail.com> wrote:
>>
>> Hi Ben
>>
>> Thank you for your patch
>>
>>> The r8a7790.dtsi file has three sdhi nodes which all have the wrong resource
>>> size for their register block. This causes the sh_modbile_sdhi driver to
>>> fail to communicate with card at-all.
>>>
>>> Change each sdhi node size from 0x100 to 0x200 to correct this.
>>>
>>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
>>> Cc: Magnus Damm <magnus.damm@gmail.com>
>>> Cc: Simon Horman <horms@verge.net.au>
>>> Cc: Linux SH <linux-sh@vger.kernel.org>
>>> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> Tested-by: William Towle <william.towle@codethink.co.uk>
>>> ---
>>
>> Unfortunately, sdhi resource size 0x100 is corrent on Renesas SDHI.
>> The wrong is SDHI/TMIO driver side, not SoC side.
>> Now, I'm working/sending sh_modbile_sdhi driver fixup patches for R-Car H2,
>> but it need more time (= there is merge timing issue)
>
> Thanks for supporting Ben regarding this SDHI issue.
>
> Would it be possible for you to share a list of patches needed to get
> SDHI working? If some parts are missing then please post them so the
> patches are available on public lists.
>
> I would like to make it possible for Ben to test your patch stack if
> he happens to have time.
Thanks, I think I have all the previous ones that where pushed to the
linux-sh list. If there's a git tree I could pull from that would make
our job easier.
We have got SDHI0 and SDHI2 working with device tree, but we're
currently seeing less than a megabyte a second when direcly dd-ing
blocks from the card. Is this a noted issue? We got ~11MiB without
DMA on the 3.4-ltsi series.
As a note, I will be away from the 20th December untill Janurary 6th
and it is likely the rest of the team here will be away from 21st.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2013-12-13 11:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 17:24 [PATCH] ARM: shmobile: r8a7790 - fix shdi resource sies Ben Dooks
2013-12-12 17:24 ` Ben Dooks
2013-12-13 2:37 ` Kuninori Morimoto
2013-12-13 2:37 ` Kuninori Morimoto
2013-12-13 8:23 ` Ben Dooks
2013-12-13 8:23 ` Ben Dooks
2013-12-13 10:56 ` Magnus Damm
2013-12-13 10:56 ` Magnus Damm
2013-12-13 11:04 ` Ben Dooks [this message]
2013-12-13 11:04 ` Ben Dooks
2013-12-14 0:27 ` Simon Horman
2013-12-14 0:27 ` Simon Horman
2013-12-16 4:18 ` Kuninori Morimoto
2013-12-16 4:18 ` Kuninori Morimoto
2013-12-16 10:59 ` Ben Dooks
2013-12-16 10:59 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AAE9AF.6010704@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.