From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: boris.ostrovsky@oracle.com, Keir Fraser <keir@xen.org>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] evtchn/fifo: map correct pages when guest is HVM
Date: Fri, 13 Dec 2013 15:14:01 +0000 [thread overview]
Message-ID: <52AB2439.8030305@citrix.com> (raw)
In-Reply-To: <20131213151052.GA5094@phenom.dumpdata.com>
On 13/12/13 15:10, Konrad Rzeszutek Wilk wrote:
> On Fri, Dec 13, 2013 at 02:49:53PM +0000, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> If a HVM guest attempts to use the FIFO-based ABI it will not receive
>> any events and destroying the guest may crash Xen or trigger an assert
>> when attempting to unmap a control block page. This occurs because
>> Xen maps the wrong page for both the control blocks and the event
>> arrays.
>>
>> In map_guest_page(), use the MFN of the guest's page and not the GFN
>> when calling map_domain_page_global().
>>
>
> Should you have the Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> flag?
Yes. I'm really bad at remembering these.
David
prev parent reply other threads:[~2013-12-13 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 14:49 [PATCH] evtchn/fifo: map correct pages when guest is HVM David Vrabel
2013-12-13 14:59 ` Jan Beulich
2013-12-13 15:06 ` David Vrabel
2013-12-13 15:10 ` Konrad Rzeszutek Wilk
2013-12-13 15:14 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB2439.8030305@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.