From: Kenneth Graunke <kenneth@whitecape.org>
To: Keith Packard <keithp@keithp.com>, mesa-dev@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888
Date: Fri, 13 Dec 2013 14:58:50 -0800 [thread overview]
Message-ID: <52AB912A.1010403@whitecape.org> (raw)
In-Reply-To: <1385093524-22276-1-git-send-email-keithp@keithp.com>
On 11/21/2013 08:12 PM, Keith Packard wrote:
> The __DRIimage createImageFromFds function takes a fourcc code, but there was
> no fourcc code that match __DRI_IMAGE_FORMAT_SARGB8. This adds a define for
> that format, adds a translation in DRI3 from __DRI_IMAGE_FORMAT_SARGB8 to
> __DRI_IMAGE_FOURCC_SARGB8888 and then adds translations *back* to
> __IMAGE_FORMAT_SARGB8 in both the i915 and i965 drivers.
>
> I'll refrain from comments on whether I think having two separate sets of
> format defines in dri_interface.h is a good idea or not...
>
> Signed-off-by: Keith Packard <keithp@keithp.com>
> ---
>
> This gets iceweasel running with the GL compositor enabled.
I see a huge discussion about this patch, but it's not obvious to me
whether there were actual concerns or just people asking questions.
I see that Eric reviewed it, and that it has not landed. Are there any
objections to merging it?
--Ken
next prev parent reply other threads:[~2013-12-13 22:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 4:12 [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888 Keith Packard
2013-11-22 10:26 ` Daniel Vetter
2013-11-22 11:01 ` [Mesa-dev] " Keith Packard
2013-11-22 16:17 ` Daniel Vetter
2013-11-22 16:17 ` Daniel Vetter
2013-11-22 16:17 ` Daniel Vetter
2013-11-22 17:46 ` Ville Syrjälä
2013-11-22 17:46 ` Ville Syrjälä
2013-11-22 22:12 ` [Intel-gfx] " Kristian Høgsberg
2013-11-22 22:12 ` Kristian Høgsberg
2013-11-22 23:05 ` Ville Syrjälä
2013-11-22 23:05 ` Ville Syrjälä
2013-11-22 23:43 ` Keith Packard
2013-11-22 23:43 ` Keith Packard
2013-11-22 23:43 ` Keith Packard
2013-11-23 1:10 ` Ville Syrjälä
2013-11-23 1:10 ` Ville Syrjälä
2013-11-25 14:57 ` Geert Uytterhoeven
2013-11-25 14:57 ` Geert Uytterhoeven
2013-11-25 14:57 ` Geert Uytterhoeven
2013-11-22 23:36 ` [Intel-gfx] " Keith Packard
2013-11-22 23:36 ` Keith Packard
2013-11-22 23:36 ` [Intel-gfx] " Keith Packard
2013-11-25 8:57 ` [Intel-gfx] [Mesa-dev] " Daniel Vetter
2013-11-25 8:57 ` Daniel Vetter
2013-11-25 8:57 ` Daniel Vetter
2013-11-25 14:15 ` [Intel-gfx] " Ville Syrjälä
2013-11-25 14:15 ` Ville Syrjälä
2013-11-25 14:15 ` Ville Syrjälä
[not found] ` <16967_1385369810_529310D2_16967_15891_1_20131125085723.GW27344@phenom.ffwll.local>
2013-11-25 15:14 ` i830 watermark problems - status? Thomas Richter
2013-11-25 15:23 ` Daniel Vetter
[not found] ` <26487_1385392973_52936B4D_26487_126_1_20131125152331.GB27344@phenom.ffwll.local>
2013-11-25 15:55 ` Thomas Richter
2013-11-25 20:30 ` Daniel Vetter
[not found] ` <26487_1385411456_5293B380_26487_2367_1_CAKMK7uFFZcf92XbzA9Mj2c0fdhDWZMKkZVNK9yy8Shc8pcLygg@mail.gmail.com>
2013-11-30 20:11 ` Thomas Richter
2013-12-19 14:01 ` intel-drm-nightly: hang and black screen on i830 Thomas Richter
2013-11-25 22:08 ` [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888 Eric Anholt
2013-12-13 22:58 ` Kenneth Graunke [this message]
2013-12-14 0:37 ` [Mesa-dev] " Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB912A.1010403@whitecape.org \
--to=kenneth@whitecape.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.