From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/23] mm/memblock: switch to use NUMA_NO_NODE instead of MAX_NUMNODES
Date: Fri, 13 Dec 2013 19:44:28 -0500 [thread overview]
Message-ID: <52ABA9EC.5070100@ti.com> (raw)
In-Reply-To: <20131213212912.GL27070@htj.dyndns.org>
On Friday 13 December 2013 04:29 PM, Tejun Heo wrote:
> On Mon, Dec 09, 2013 at 04:50:40PM -0500, Santosh Shilimkar wrote:
>> + if (nid == MAX_NUMNODES)
>> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
>> + __func__);
>
> Why not just use WARN_ONCE()? We'd want to know who the caller is
> anyway. Also, wouldn't something like the following simpler?
>
> if (WARN_ONCE(nid == MAX_NUMNODES, blah blah))
> nid = NUMA_NO_NODE;
>
Agree.
>> @@ -768,6 +773,11 @@ void __init_memblock __next_free_mem_range_rev(u64 *idx, int nid,
>> struct memblock_type *rsv = &memblock.reserved;
>> int mi = *idx & 0xffffffff;
>> int ri = *idx >> 32;
>> + bool check_node = (nid != NUMA_NO_NODE) && (nid != MAX_NUMNODES);
>> +
>> + if (nid == MAX_NUMNODES)
>> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
>> + __func__);
>
> Ditto.
>
OK.
>
> Reviwed-by: Tejun Heo <tj@kernel.org>
>
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
Grygorii Strashko <grygorii.strashko@ti.com>,
Yinghai Lu <yinghai@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 07/23] mm/memblock: switch to use NUMA_NO_NODE instead of MAX_NUMNODES
Date: Fri, 13 Dec 2013 19:44:28 -0500 [thread overview]
Message-ID: <52ABA9EC.5070100@ti.com> (raw)
In-Reply-To: <20131213212912.GL27070@htj.dyndns.org>
On Friday 13 December 2013 04:29 PM, Tejun Heo wrote:
> On Mon, Dec 09, 2013 at 04:50:40PM -0500, Santosh Shilimkar wrote:
>> + if (nid == MAX_NUMNODES)
>> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
>> + __func__);
>
> Why not just use WARN_ONCE()? We'd want to know who the caller is
> anyway. Also, wouldn't something like the following simpler?
>
> if (WARN_ONCE(nid == MAX_NUMNODES, blah blah))
> nid = NUMA_NO_NODE;
>
Agree.
>> @@ -768,6 +773,11 @@ void __init_memblock __next_free_mem_range_rev(u64 *idx, int nid,
>> struct memblock_type *rsv = &memblock.reserved;
>> int mi = *idx & 0xffffffff;
>> int ri = *idx >> 32;
>> + bool check_node = (nid != NUMA_NO_NODE) && (nid != MAX_NUMNODES);
>> +
>> + if (nid == MAX_NUMNODES)
>> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
>> + __func__);
>
> Ditto.
>
OK.
>
> Reviwed-by: Tejun Heo <tj@kernel.org>
>
Thanks
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-arm-kernel@lists.infradead.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Yinghai Lu <yinghai@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 07/23] mm/memblock: switch to use NUMA_NO_NODE instead of MAX_NUMNODES
Date: Fri, 13 Dec 2013 19:44:28 -0500 [thread overview]
Message-ID: <52ABA9EC.5070100@ti.com> (raw)
In-Reply-To: <20131213212912.GL27070@htj.dyndns.org>
On Friday 13 December 2013 04:29 PM, Tejun Heo wrote:
> On Mon, Dec 09, 2013 at 04:50:40PM -0500, Santosh Shilimkar wrote:
>> + if (nid == MAX_NUMNODES)
>> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
>> + __func__);
>
> Why not just use WARN_ONCE()? We'd want to know who the caller is
> anyway. Also, wouldn't something like the following simpler?
>
> if (WARN_ONCE(nid == MAX_NUMNODES, blah blah))
> nid = NUMA_NO_NODE;
>
Agree.
>> @@ -768,6 +773,11 @@ void __init_memblock __next_free_mem_range_rev(u64 *idx, int nid,
>> struct memblock_type *rsv = &memblock.reserved;
>> int mi = *idx & 0xffffffff;
>> int ri = *idx >> 32;
>> + bool check_node = (nid != NUMA_NO_NODE) && (nid != MAX_NUMNODES);
>> +
>> + if (nid == MAX_NUMNODES)
>> + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n",
>> + __func__);
>
> Ditto.
>
OK.
>
> Reviwed-by: Tejun Heo <tj@kernel.org>
>
Thanks
next prev parent reply other threads:[~2013-12-14 0:44 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 21:50 [PATCH v3 00/23] mm: Use memblock interface instead of bootmem Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 01/23] mm/memblock: debug: correct displaying of upper memory boundary Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:56 ` Felipe Balbi
2013-12-09 21:56 ` Felipe Balbi
2013-12-09 21:56 ` Felipe Balbi
2013-12-09 22:39 ` Santosh Shilimkar
2013-12-09 22:39 ` Santosh Shilimkar
2013-12-09 22:39 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 02/23] mm/memblock: debug: don't free reserved array if !ARCH_DISCARD_MEMBLOCK Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-10 0:11 ` Andrew Morton
2013-12-10 0:11 ` Andrew Morton
2013-12-10 0:11 ` Andrew Morton
2013-12-10 16:44 ` Grygorii Strashko
2013-12-10 16:44 ` Grygorii Strashko
2013-12-10 16:44 ` Grygorii Strashko
2013-12-09 21:50 ` [PATCH v3 03/23] mm/bootmem: remove duplicated declaration of __free_pages_bootmem() Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 04/23] mm/memblock: remove unnecessary inclusions of bootmem.h Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 05/23] mm/memblock: drop WARN and use SMP_CACHE_BYTES as a default alignment Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-13 21:21 ` Tejun Heo
2013-12-13 21:21 ` Tejun Heo
2013-12-13 21:21 ` Tejun Heo
2013-12-09 21:50 ` [PATCH v3 06/23] mm/memblock: reorder parameters of memblock_find_in_range_node Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-13 21:22 ` Tejun Heo
2013-12-13 21:22 ` Tejun Heo
2013-12-13 21:22 ` Tejun Heo
2013-12-09 21:50 ` [PATCH v3 07/23] mm/memblock: switch to use NUMA_NO_NODE instead of MAX_NUMNODES Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-13 21:29 ` Tejun Heo
2013-12-13 21:29 ` Tejun Heo
2013-12-13 21:29 ` Tejun Heo
2013-12-14 0:44 ` Santosh Shilimkar [this message]
2013-12-14 0:44 ` Santosh Shilimkar
2013-12-14 0:44 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 08/23] mm/memblock: Add memblock memory allocation apis Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-10 0:25 ` Andrew Morton
2013-12-10 0:25 ` Andrew Morton
2013-12-10 0:25 ` Andrew Morton
2013-12-10 16:04 ` Santosh Shilimkar
2013-12-10 16:04 ` Santosh Shilimkar
2013-12-10 16:04 ` Santosh Shilimkar
2013-12-13 21:37 ` Tejun Heo
2013-12-13 21:37 ` Tejun Heo
2013-12-13 21:37 ` Tejun Heo
2013-12-14 0:52 ` Santosh Shilimkar
2013-12-14 0:52 ` Santosh Shilimkar
2013-12-14 0:52 ` Santosh Shilimkar
2013-12-14 11:08 ` Tejun Heo
2013-12-14 11:08 ` Tejun Heo
2013-12-14 11:08 ` Tejun Heo
2013-12-14 19:48 ` Santosh Shilimkar
2013-12-14 19:48 ` Santosh Shilimkar
2013-12-14 19:48 ` Santosh Shilimkar
2013-12-20 22:30 ` Santosh Shilimkar
2013-12-20 22:30 ` Santosh Shilimkar
2013-12-20 22:30 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 09/23] mm/init: Use memblock apis for early memory allocations Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 10/23] mm/printk: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 11/23] mm/page_alloc: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 12/23] mm/power: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 13/23] mm/lib/swiotlb: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-13 1:08 ` Andrew Morton
2013-12-13 1:08 ` Andrew Morton
2013-12-13 1:24 ` Santosh Shilimkar
2013-12-13 1:24 ` Santosh Shilimkar
2013-12-13 1:24 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 14/23] mm/lib/cpumask: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 15/23] mm/sparse: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 16/23] mm/hugetlb: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 17/23] mm/page_cgroup: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 18/23] mm/percpu: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 19/23] mm/memory_hotplug: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 20/23] mm/firmware: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 21/23] mm/ARM: kernel: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 22/23] mm/ARM: mm: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` [PATCH v3 23/23] mm/ARM: OMAP: " Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
2013-12-09 21:50 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ABA9EC.5070100@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.