From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Russell King <linux@arm.linux.org.uk>,
netdev@vger.kernel.org, Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Eric Miao <eric.y.miao@gmail.com>,
Wolfgang Grandegger <wg@grandegger.com>,
dbaryshkov@gmail.com
Subject: Re: [PATCH 1/3] can: mcp251x: Convert driver to use common clk framework
Date: Sat, 14 Dec 2013 14:18:21 +0100 [thread overview]
Message-ID: <52AC5A9D.3010703@pengutronix.de> (raw)
In-Reply-To: <20131214091507.35557bcf132c885cfba69008@mail.ru>
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
On 12/14/2013 06:15 AM, Alexander Shiyan wrote:
> On Wed, 13 Nov 2013 10:04:39 +0100
> Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
>> as this series adds device tree bindings, please add
>> devicetree@vger.kernel.org on Cc for the whole series.
>>
>> On 11/13/2013 09:42 AM, Alexander Shiyan wrote:
>>> This patch converts mcp251x driver to using common clk framework
>>> for getting input frequency. The change was made for the preparation
>>> of the driver work with the devicetree. As a result private header
>>> for the driver is eliminated.
>>> Additionally, all existing users of the driver was converted to use
>>> this feature.
>>>
>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>
>> Looks good from my point of view. I'll take the whole series via the
>> linux-can tree, if there are no objections. I'd like to have the pxa and
>> imx maintainer's Ack and an Ack from the DT list.
>>
>> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Ping. Resend?
Is Dmitry's comment still valid?
PXA does not employ COMMON_CLK yet (WIP locally, but it is not finished
yet), so clk_register_fixed() will probably fail.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] can: mcp251x: Convert driver to use common clk framework
Date: Sat, 14 Dec 2013 14:18:21 +0100 [thread overview]
Message-ID: <52AC5A9D.3010703@pengutronix.de> (raw)
In-Reply-To: <20131214091507.35557bcf132c885cfba69008@mail.ru>
On 12/14/2013 06:15 AM, Alexander Shiyan wrote:
> On Wed, 13 Nov 2013 10:04:39 +0100
> Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
>> as this series adds device tree bindings, please add
>> devicetree at vger.kernel.org on Cc for the whole series.
>>
>> On 11/13/2013 09:42 AM, Alexander Shiyan wrote:
>>> This patch converts mcp251x driver to using common clk framework
>>> for getting input frequency. The change was made for the preparation
>>> of the driver work with the devicetree. As a result private header
>>> for the driver is eliminated.
>>> Additionally, all existing users of the driver was converted to use
>>> this feature.
>>>
>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>
>> Looks good from my point of view. I'll take the whole series via the
>> linux-can tree, if there are no objections. I'd like to have the pxa and
>> imx maintainer's Ack and an Ack from the DT list.
>>
>> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Ping. Resend?
Is Dmitry's comment still valid?
PXA does not employ COMMON_CLK yet (WIP locally, but it is not finished
yet), so clk_register_fixed() will probably fail.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131214/b659ef1e/attachment.sig>
next prev parent reply other threads:[~2013-12-14 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:42 [PATCH 1/3] can: mcp251x: Convert driver to use common clk framework Alexander Shiyan
2013-11-13 8:42 ` Alexander Shiyan
2013-11-13 9:04 ` Marc Kleine-Budde
2013-11-13 9:04 ` Marc Kleine-Budde
2013-12-14 5:15 ` Alexander Shiyan
2013-12-14 5:15 ` Alexander Shiyan
2013-12-14 13:18 ` Marc Kleine-Budde [this message]
2013-12-14 13:18 ` Marc Kleine-Budde
2013-12-14 13:35 ` Alexander Shiyan
2013-12-14 13:35 ` Alexander Shiyan
2013-11-13 17:59 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AC5A9D.3010703@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dbaryshkov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.