Re: [Qemu-devel] [PATCH v4 02/10] sysbus: Set cannot_instantiate_with_device_add_yet

["Andreas Färber" <afaerber@suse.de>]

Am 28.11.2013 17:26, schrieb armbru@redhat.com:
> diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
> index 146f50a..ed0477b 100644
> --- a/hw/core/sysbus.c
> +++ b/hw/core/sysbus.c
> @@ -257,6 +257,13 @@ static void sysbus_device_class_init(ObjectClass *klass, void *data)
>      DeviceClass *k = DEVICE_CLASS(klass);
>      k->init = sysbus_device_init;
>      k->bus_type = TYPE_SYSTEM_BUS;
> +    /*
> +     * device_add plugs devices into suitable bus.  For "real" buses,
> +     * that actually connects the device.  For sysbus, the connections
> +     * need to be made separately, and device_add can't do that.  The
> +     * device would be left unconncected, and could not possibly work.

"unconnected" - fixed.

Andreas

> +     */
> +    k->cannot_instantiate_with_device_add_yet = true;
>  }
>  
>  static const TypeInfo sysbus_device_type_info = {

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg