Re: [PATCH v4 01/11] pvh dom0: Introduce p2m_map_foreign

[George Dunlap <george.dunlap@eu.citrix.com>]

On 12/16/2013 10:45 AM, Ian Campbell wrote:
> On Sat, 2013-12-14 at 00:00 +0000, Julien Grall wrote:
>> On 12/13/2013 11:19 PM, Ian Campbell wrote:
>>> On Fri, 2013-12-13 at 19:37 +0000, Julien Grall wrote:
>>>> From: Mukesh Rathor <mukesh.rathor@oracle.com>
>>>>
>>>> In this patch, a new type p2m_map_foreign is introduced for pages
>>>> that toolstack on PVH dom0 maps from foreign domains that its creating
>>>> or supporting during it's run time.
>>>>
>>>> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
>>>> Cc: Jan Beulich <jbeulich@suse.com>
>>>> Cc: Keir Fraser <keir@xen.org>
>>>> Cc: George Dunlap <george.dunlap@eu.citrix.com>
>>>>
>>>> ---
>>>>       Changes in v4:
>>>>           - Use the patch #4 from dom0 pvh v6 series. We need it for ARM
>>> Is this really the right patch? I'd have thought it would need to
>>> include some generic/!x86 bits but:
>> This patch introduce p2m_map_foreign type. I think it's safe to push it
>> without the other patches.
> Is it really that simple? I suppose there is nothing to create a foreign
> mapping on x86 yet so this is harmless?
>
> I'm mostly concerned because the big remaining concern about this stuff
> on x86 relates to the reference counting of foreign p2m entries. I'll
> defer to the x86 chaps about whether that conversation is directly
> related to or impacts this patch or not.

Do you have the reference counting for the new p2m type sorted out 
sufficiently?

  -George