All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [BUG] P2P setup timeout
Date: Mon, 16 Dec 2013 16:37:59 +0100	[thread overview]
Message-ID: <52AF1E57.2040300@rempel-privat.de> (raw)
In-Reply-To: <1387207795.2057.29.camel@jlt4.sipsolutions.net>

Am 16.12.2013 16:29, schrieb Johannes Berg:
> On Mon, 2013-12-16 at 16:26 +0100, Oleksij Rempel wrote:
>> Am 16.12.2013 16:15, schrieb Johannes Berg:
>>> On Mon, 2013-12-16 at 16:09 +0100, David Herrmann wrote:
>>>
>>>> Thanks, I tracked down the ENETDOWN. I'm not entirely sure but I think it's:
>>>
>>> Obviously :)
>>>
>>>> @Oleksij, I actually have three ath9k-htc devices so I'd like to get
>>>> this working, and the devices are really nice apart from this bug. I
>>>> will keep you up to date, but if you have any hints where to continue
>>>> digging, lemme know. Until it's fixed, I'll just work on
>>>> wired-displays via ethernet instead of wifi-displays..
>>>
>>> Based on what Oleksij said, these issues are likely not even related -
>>> maybe ath9k_htc can't even set the rates to exclude CCK, so even if that
>>> call were to succeed it wouldn't work?
>>
>> Hmm.. WMI_BITRATE_MASK should do it.
>> ieee80211_ops->set_bitrate_mask is set, so theoretically we should be
>> able to exclude CCK. Today i won't be able to check it.
> 
> There are two things:
>  * the issue at hand, which is only for some certain management frames
> that I
>    believe are sent over the normal wlan0 netdev/vif, but still must not
> use CCK
>    even though wlan0 allows CCK
>  * the issue about the set tx-rate on the p2p netdev/vif, which is how I
> noticed
>    this, but which is actually not related to the current bug
> 
> It sounds to me like only the latter can be solved with WMI_BITRATE_MASK
> since you can't generally disable CCK on wlan0 when doing P2P (you might
> be connected to an 11b AP at the same time)
> 
> For the latter issue, you really need a per-frame "disable CCK" flag in
> the firmware, or you need to use a P2P_DEVICE vif.

Ah.. there is comment which clarify the situation with
ieee80211_ops->set_bitrate_mask in ath9k_htc:
/*
 * Currently, this is used only for selecting the minimum rate
 * for management frames, rate selection for data frames remain
 * unaffected.
 */

-- 
Regards,
Oleksij

WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux@rempel-privat.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Herrmann <dh.herrmann@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [BUG] P2P setup timeout
Date: Mon, 16 Dec 2013 16:37:59 +0100	[thread overview]
Message-ID: <52AF1E57.2040300@rempel-privat.de> (raw)
In-Reply-To: <1387207795.2057.29.camel@jlt4.sipsolutions.net>

Am 16.12.2013 16:29, schrieb Johannes Berg:
> On Mon, 2013-12-16 at 16:26 +0100, Oleksij Rempel wrote:
>> Am 16.12.2013 16:15, schrieb Johannes Berg:
>>> On Mon, 2013-12-16 at 16:09 +0100, David Herrmann wrote:
>>>
>>>> Thanks, I tracked down the ENETDOWN. I'm not entirely sure but I think it's:
>>>
>>> Obviously :)
>>>
>>>> @Oleksij, I actually have three ath9k-htc devices so I'd like to get
>>>> this working, and the devices are really nice apart from this bug. I
>>>> will keep you up to date, but if you have any hints where to continue
>>>> digging, lemme know. Until it's fixed, I'll just work on
>>>> wired-displays via ethernet instead of wifi-displays..
>>>
>>> Based on what Oleksij said, these issues are likely not even related -
>>> maybe ath9k_htc can't even set the rates to exclude CCK, so even if that
>>> call were to succeed it wouldn't work?
>>
>> Hmm.. WMI_BITRATE_MASK should do it.
>> ieee80211_ops->set_bitrate_mask is set, so theoretically we should be
>> able to exclude CCK. Today i won't be able to check it.
> 
> There are two things:
>  * the issue at hand, which is only for some certain management frames
> that I
>    believe are sent over the normal wlan0 netdev/vif, but still must not
> use CCK
>    even though wlan0 allows CCK
>  * the issue about the set tx-rate on the p2p netdev/vif, which is how I
> noticed
>    this, but which is actually not related to the current bug
> 
> It sounds to me like only the latter can be solved with WMI_BITRATE_MASK
> since you can't generally disable CCK on wlan0 when doing P2P (you might
> be connected to an 11b AP at the same time)
> 
> For the latter issue, you really need a per-frame "disable CCK" flag in
> the firmware, or you need to use a P2P_DEVICE vif.

Ah.. there is comment which clarify the situation with
ieee80211_ops->set_bitrate_mask in ath9k_htc:
/*
 * Currently, this is used only for selecting the minimum rate
 * for management frames, rate selection for data frames remain
 * unaffected.
 */

-- 
Regards,
Oleksij

  reply	other threads:[~2013-12-16 15:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 10:18 [BUG] P2P setup timeout David Herrmann
2013-12-09 14:03 ` Oleksij Rempel
2013-12-09 14:30   ` David Herrmann
2013-12-16 12:00 ` David Herrmann
2013-12-16 12:36 ` Johannes Berg
2013-12-16 13:39   ` David Herrmann
2013-12-16 13:45     ` Johannes Berg
2013-12-16 13:51       ` David Herrmann
2013-12-16 14:57         ` [ath9k-devel] " Oleksij Rempel
2013-12-16 14:57           ` Oleksij Rempel
2013-12-16 15:09           ` [ath9k-devel] " David Herrmann
2013-12-16 15:09             ` David Herrmann
2013-12-16 15:15             ` [ath9k-devel] " Johannes Berg
2013-12-16 15:15               ` Johannes Berg
2013-12-16 15:26               ` [ath9k-devel] " Oleksij Rempel
2013-12-16 15:26                 ` Oleksij Rempel
2013-12-16 15:29                 ` [ath9k-devel] " Johannes Berg
2013-12-16 15:29                   ` Johannes Berg
2013-12-16 15:37                   ` Oleksij Rempel [this message]
2013-12-16 15:37                     ` Oleksij Rempel
2013-12-16 15:53                     ` [ath9k-devel] " David Herrmann
2013-12-16 15:53                       ` David Herrmann
2013-12-17  5:50       ` Ujjal Roy
2013-12-17  7:19         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AF1E57.2040300@rempel-privat.de \
    --to=linux@rempel-privat.de \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.