From: Stephen Warren <swarren@wwwdotorg.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] spi: tegra: checking for ERR_PTR instead of NULL
Date: Mon, 16 Dec 2013 16:55:47 +0000 [thread overview]
Message-ID: <52AF3093.30308@wwwdotorg.org> (raw)
In-Reply-To: <20131216140210.GA32033@elgon.mountain>
On 12/16/2013 07:02 AM, Dan Carpenter wrote:
> dma_request_slave_channel() returns NULL on error and not ERR_PTRs.
> I've fixed this by using dma_request_slave_channel_reason() which does
> return ERR_PTRs.
>
> Fixes: a915d150f68d ('spi: tegra: convert to standard DMA DT bindings')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops. I validate there aren't any more issues like this, at least in the
commits in the series this fixes.
I've applied this to Tegra's for-3.14/dmas-resets-rework branch, since
that's the only place where the commit this fixes exists.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] spi: tegra: checking for ERR_PTR instead of NULL
Date: Mon, 16 Dec 2013 09:55:47 -0700 [thread overview]
Message-ID: <52AF3093.30308@wwwdotorg.org> (raw)
In-Reply-To: <20131216140210.GA32033@elgon.mountain>
On 12/16/2013 07:02 AM, Dan Carpenter wrote:
> dma_request_slave_channel() returns NULL on error and not ERR_PTRs.
> I've fixed this by using dma_request_slave_channel_reason() which does
> return ERR_PTRs.
>
> Fixes: a915d150f68d ('spi: tegra: convert to standard DMA DT bindings')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops. I validate there aren't any more issues like this, at least in the
commits in the series this fixes.
I've applied this to Tegra's for-3.14/dmas-resets-rework branch, since
that's the only place where the commit this fixes exists.
next prev parent reply other threads:[~2013-12-16 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 14:02 [patch] spi: tegra: checking for ERR_PTR instead of NULL Dan Carpenter
2013-12-16 14:02 ` Dan Carpenter
2013-12-16 16:55 ` Stephen Warren [this message]
2013-12-16 16:55 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF3093.30308@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.