Re: Removal of EXPORT_SYMBOL(acpi_os_wait_events_complete) in 3.13

Re: Removal of EXPORT_SYMBOL(acpi_os_wait_events_complete) in 3.13

[Rafael J. Wysocki]

On 12/12/2013 9:50 PM, Josh Boyer wrote:
> Hi Rafael,

Hi,

> We had a user report[1] their nvidia driver failing to load on 3.13
> because acpi_os_wait_events_complete is no longer exported.  They
> believe it was in error and I told them to contact you.  Just in case
> they don't bother to do that,

Well, they haven't so far. :-)

>   I thought I'd send you a quick email
> about it.  The commit in question is:
>
> commit 7b98118aaa5d75644c48f41fc5d0cc181e478383
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date:   Thu Nov 7 01:45:40 2013 +0100
>
>      ACPI / hotplug: Consolidate deferred execution of ACPI hotplug routines
>
>
> and it doesn't mention anything about unexporting that symbol in the changelog.

It doesn't, but removing the export was intentional, because that export 
is not needed for any in-the-tree modules any more.

In principle I can add the export back, but this function is supposed to 
be an internal ACPI interface and the NVidia driver is abusing it quite 
openly, so I'm not sure.  I guess I'll just send a patch for broader 
discussion.

Thanks,
Rafael

Re: Removal of EXPORT_SYMBOL(acpi_os_wait_events_complete) in 3.13

[Josh Boyer]

On Tue, Dec 17, 2013 at 11:59 AM, Rafael J. Wysocki
<rafael.j.wysocki@intel.com> wrote:
> On 12/12/2013 9:50 PM, Josh Boyer wrote:
>>
>> Hi Rafael,
>
>
> Hi,
>
>
>> We had a user report[1] their nvidia driver failing to load on 3.13
>> because acpi_os_wait_events_complete is no longer exported.  They
>> believe it was in error and I told them to contact you.  Just in case
>> they don't bother to do that,
>
>
> Well, they haven't so far. :-)
>
>
>>   I thought I'd send you a quick email
>> about it.  The commit in question is:
>>
>> commit 7b98118aaa5d75644c48f41fc5d0cc181e478383
>> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Date:   Thu Nov 7 01:45:40 2013 +0100
>>
>>      ACPI / hotplug: Consolidate deferred execution of ACPI hotplug
>> routines
>>
>>
>> and it doesn't mention anything about unexporting that symbol in the
>> changelog.
>
>
> It doesn't, but removing the export was intentional, because that export is
> not needed for any in-the-tree modules any more.
>
> In principle I can add the export back, but this function is supposed to be
> an internal ACPI interface and the NVidia driver is abusing it quite openly,
> so I'm not sure.  I guess I'll just send a patch for broader discussion.

Eh.  If it was an intentional then I personally wouldn't bother to put
it back just to satisfy an out-of-tree user.  Particularly one where
you have no idea what they're using it for.

josh