All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matias Bjørling" <m@bjorling.me>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
	Ming Lei <tom.leiming@gmail.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Huang Ying <ying.huang@intel.com>, Jens Axboe <axboe@kernel.dk>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: changes caused by 0d11e6ac("blk-mq: fix use-after-free of request")
Date: Wed, 18 Dec 2013 11:29:30 +0100	[thread overview]
Message-ID: <52B1790A.5070105@bjorling.me> (raw)
In-Reply-To: <20131218085007.GP31783@yliu-dev.sh.intel.com>

On 12/18/2013 09:50 AM, Yuanhan Liu wrote:
> Hi,
>
> FYI, we noticed some changes caused by 0d11e6ac("blk-mq: fix use-after-free of request"):
>

The blk-mq accounting was faulty up to that commit. We should compare 
the blk-mq with the previous block layer.

Could you try to revert the following patches:

f02b9ac virtio-blk: virtqueue_kick() must be ordered with other...
1cf7e9c virtio_blk: blk-mq support

and compare the two runs (upto 0d11e6ac applied, and the same, with the 
two patches reverted)

Thanks

<snip>

  reply	other threads:[~2013-12-18 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18  8:50 changes caused by 0d11e6ac("blk-mq: fix use-after-free of request") Yuanhan Liu
2013-12-18 10:29 ` Matias Bjørling [this message]
2013-12-19 14:37   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B1790A.5070105@bjorling.me \
    --to=m@bjorling.me \
    --cc=axboe@kernel.dk \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=ying.huang@intel.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.